chore(store): Removed unused store implementation #2020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, let's wait for #2019 to be merged. |
twolfson
force-pushed
the
dev/remove.store.sqwished
branch
from
6c62b87
to
33eb83a
Compare
|
Updated this PR to use latest changes from #2019 |
|
Restarted CI will merge when those are green |
|
I hit "Update branch" but it looks like those are creating merge commits instead of doing a rebase. I'm going to rebase in a bit. |
…ularity BREAKING CHANGE: Our `context.html` and `debug.html` structures have changed to lean on `context.js` and `debug.js`. This is in preparation for deeper `context.js` changes in karma-runner#1984. As a result, all `customContextFile` and `customDebugFile` options much update their format to match this new format.
twolfson
force-pushed
the
dev/remove.store.sqwished
branch
from
4bec8ed
to
996753c
Compare
|
Rebase has been completed |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2019, please only review HEAD commit
In #1984 we discussed removing
karma.storeas it's no longer used and not portable to environments like Electron (due to wanting to share astoreacross multiple processes).#1984 (comment)
In this PR:
storeimplementation fromclientanddebugenvironmentsstoretests