fix(file-list): ensure patterns are comparable #2277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to @m-a-r-c-e-l-i-n-o for pointing me in the right direction Fixes #2194
| @@ -230,6 +231,13 @@ Object.defineProperty(List.prototype, 'files', { | |||
| var lookup = {} | |||
| var included = {} | |||
| this._patterns.forEach(function (p) { | |||
| // This needs to be here sadly, as plugins are modifiying | |||
| // the _patterns directly resulting in elements not being | |||
There was a problem hiding this comment.
@dignifiedquire for my own edification, can you give an example of a plugin doing this? Specifically, is karm-jspm doing this?
|
yes this is one place https://github.com/Workiva/karma-jspm/blob/master/src/init.js#L106 |
|
Ah, understood. LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @m-a-r-c-e-l-i-n-o for pointing me in the right direction
Fixes #2194
This supersedes #2255
Also fixes