Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update socket.io to version 2.0.3. #2880

Merged
merged 1 commit into from
Nov 15, 2017

Conversation

johnjbarton
Copy link
Contributor

This is a duplicate of @kevinsalter PR #2821. I am re-sending after appveyor fixup.
(We don't seem to have the ability to retry appveyor builds).

Fixes #2777

This is a duplicate of @kevinsalter PR karma-runner#2821. I am re-sending after appveyor fixup.
(We don't seem to have the ability to retry appveyor builds).

Fixes karma-runner#2777
@dignifiedquire
Copy link
Member

@zzo @johnjbarton did you check that all IE versions are still supported with this new socket.io version?

Users currently rely on support back to IE7, where as socket.io doesn't test those currently: https://github.com/socketio/socket.io#cross-browser

Looks like the reason for this is socketio/engine.io-client#581 saucelabs doesn't support testing on IE 7 anymore.

@mgol could you check if things are still working fine for you on the latest master please?

@pedrosimoes-nbr
Copy link

@dignifiedquire et al. thanks for your good work. Are you planning to quickly release this fix on the npm repository? At least for me, it solved the related issue.

@herringtown
Copy link

any status updated on this?

@dignifiedquire
Copy link
Member

@herringtown 2.0 was released, which includes this fix

@pedrosimoes79
Copy link

Thks

@mgol
Copy link
Contributor

mgol commented Mar 21, 2018

@dignifiedquire Sorry for the late reply. I've tried Karma 2.0 but IE 7 still didn't run correctly. See the Travis run and the relevant commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read property 'isValidUTF8' of undefined
7 participants