refactor(middleware): update middleware/common to ES6 #3028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lusarz
reviewed
Jun 5, 2018
lib/middleware/common.js
Outdated
| @@ -117,7 +120,7 @@ var createServeFile = function (fs, directory, config) { | |||
| responseData = (transform && transform(data.toString())) || data | |||
|
|
|||
| if (rangeHeader) { | |||
| var code = convertForRangeRequest() | |||
| const code = convertForRangeRequest() | |||
There was a problem hiding this comment.
You can update L122-L127 into response.writeHead(rangeHeader ? convertForRangeRequest() : 200).
Same with L97-L101
lusarz
reviewed
Jun 5, 2018
lib/middleware/common.js
Outdated
| log.warn('404: ' + path) | ||
| response.writeHead(404) | ||
| return response.end('NOT FOUND') | ||
| } | ||
|
|
||
| var createServeFile = function (fs, directory, config) { | ||
| var cache = Object.create(null) | ||
| const createServeFile = function (fs, directory, config) { |
There was a problem hiding this comment.
What do you think about function createServeFile (fs, directory, config) instead of const ?
There was a problem hiding this comment.
done (also others)
johnjbarton
force-pushed
the
middleware-es6
branch
from
9fa79eb
to
7232042
Compare
lusarz
approved these changes
Jun 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.