refactor(web-server): update lib/web-server to ES6 #3034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lusarz
changed the title
johnjbarton
suggested changes
Jun 11, 2018
| } | ||
| } | ||
|
|
||
| createCustomHandler.$inject = ['customFileHandlers', 'config.basePath'] |
There was a problem hiding this comment.
Where did the injection keys end up?
There was a problem hiding this comment.
I removed them. Dependency injection framework use autoAnnonate in that case (read function parameter names)
https://github.com/vojtajina/node-di/blob/master/lib/injector.js#L70
After consideration I think it would be better to use $inject - I'm gonna fix it now.
There was a problem hiding this comment.
BTW, are customFileHandlers used in some way ? I see they are initialized here:
Lines 74 to 75 in 011a90c
as empty array, and never changed (also comment 'TODO: remove' exists). Maybe we can get rid of everything related with that ?
There was a problem hiding this comment.
Revert $inject - done
johnjbarton
approved these changes
Jun 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.