refactor(launcher): use this directly instead assign to self variable in base launcher #3157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in base launcher
devoto13
reviewed
Oct 3, 2018
| @@ -41,7 +40,7 @@ function BaseLauncher (id, emitter) { | |||
|
|
|||
| this.error = null | |||
| this.state = BEING_CAPTURED | |||
| this.emit('start', url + '?id=' + this.id + (helper.isDefined(self.displayName) ? '&displayName=' + encodeURIComponent(self.displayName) : '')) | |||
| this.emit('start', url + '?id=' + this.id + (helper.isDefined(this.displayName) ? '&displayName=' + encodeURIComponent(this.displayName) : '')) | |||
| } | |||
|
|
|||
| this.kill = function () { | |||
There was a problem hiding this comment.
I think you should also change this.start and this.kill to be arrow functions to be on the safe side. Not 100% sure, because of inheritance.
johnjbarton
approved these changes
Oct 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is the first step that should help us to transform
BaseLauncherto be ES6 class