Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update braces and chokidar to latest versions #3307

Merged
merged 1 commit into from May 15, 2019

Conversation

devoto13
Copy link
Collaborator

This results in a significant dependencies reduction from braces refactor. New version of chokidar also promises significant memory and CPU usage improvements.

@devoto13
Copy link
Collaborator Author

Interesting, none of the tests failed locally. I'll investigate it tomorrow.

@johnjbarton
Copy link
Contributor

Looks like this is windows vs linux file system issue.

This results in a significant dependencies reduction. New version of
chokidar also promises significant memory and performance improvements.
@devoto13
Copy link
Collaborator Author

devoto13 commented May 15, 2019

Turns out braces was updated to strip escape characters (\ - which is also Windows path separator) by default: micromatch/braces#27. Adjusted configuration to keep current behaviour of keeping them.

@johnjbarton johnjbarton merged commit 7828bea into karma-runner:master May 15, 2019
@devoto13 devoto13 deleted the dependencies branch May 15, 2019 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants