-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
small refactoring #3401
small refactoring #3401
Conversation
✅ Build karma 59 completed (commit d4d3804759 by @anthony-redFox) |
✅ Build karma 2457 completed (commit d4d3804759 by @anthony-redFox) |
✅ Build karma 58 completed (commit d4d3804759 by @anthony-redFox) |
b094c80
to
55c5ab4
Compare
✅ Build karma 2471 completed (commit 070f600af8 by @anthony-redFox) |
✅ Build karma 73 completed (commit 070f600af8 by @anthony-redFox) |
✅ Build karma 72 completed (commit 070f600af8 by @anthony-redFox) |
@johnjbarton cc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks.
Really sorry for the delay. We've switched to commitlint and semantic release. That means merged commits will drive the release (yay). But the commits need to be describe in a formatted way. Can you rebase and repush? That will force you through the commitlint. I guess yours would be something like |
55c5ab4
to
0c17009
Compare
initializeMimeTypes.
0c17009
to
a77b371
Compare
✅ Build karma 89 completed (commit 917c8212b6 by @anthony-redFox) |
✅ Build karma 2487 completed (commit 917c8212b6 by @anthony-redFox) |
@johnjbarton done |
✅ Build karma 88 completed (commit 917c8212b6 by @anthony-redFox) |
✅ Build karma 2488 completed (commit 1e40ad5d95 by @anthony-redFox) |
✅ Build karma 90 completed (commit 1e40ad5d95 by @anthony-redFox) |
✅ Build karma 89 completed (commit 1e40ad5d95 by @anthony-redFox) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.