Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small refactoring #3401

Merged
merged 1 commit into from
Feb 24, 2020
Merged

small refactoring #3401

merged 1 commit into from
Feb 24, 2020

Conversation

anthony-redFox
Copy link
Contributor

No description provided.

@karmarunnerbot
Copy link
Member

Build karma 59 completed (commit d4d3804759 by @anthony-redFox)

@AppVeyorBot
Copy link

Build karma 2457 completed (commit d4d3804759 by @anthony-redFox)

@karmarunnerbot
Copy link
Member

Build karma 58 completed (commit d4d3804759 by @anthony-redFox)

@AppVeyorBot
Copy link

Build karma 2471 completed (commit 070f600af8 by @anthony-redFox)

@karmarunnerbot
Copy link
Member

Build karma 73 completed (commit 070f600af8 by @anthony-redFox)

@karmarunnerbot
Copy link
Member

Build karma 72 completed (commit 070f600af8 by @anthony-redFox)

@anthony-redFox
Copy link
Contributor Author

@johnjbarton cc

Copy link
Contributor

@johnjbarton johnjbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks.

@johnjbarton
Copy link
Contributor

Really sorry for the delay.

We've switched to commitlint and semantic release. That means merged commits will drive the release (yay). But the commits need to be describe in a formatted way.

Can you rebase and repush? That will force you through the commitlint. I guess yours would be something like
chore(server): Convert PromiseContainer to object and remove initializeMimeTypes.

@karmarunnerbot
Copy link
Member

Build karma 89 completed (commit 917c8212b6 by @anthony-redFox)

@AppVeyorBot
Copy link

Build karma 2487 completed (commit 917c8212b6 by @anthony-redFox)

@anthony-redFox
Copy link
Contributor Author

@johnjbarton done

@karmarunnerbot
Copy link
Member

Build karma 88 completed (commit 917c8212b6 by @anthony-redFox)

@AppVeyorBot
Copy link

Build karma 2488 completed (commit 1e40ad5d95 by @anthony-redFox)

@karmarunnerbot
Copy link
Member

Build karma 90 completed (commit 1e40ad5d95 by @anthony-redFox)

@karmarunnerbot
Copy link
Member

Build karma 89 completed (commit 1e40ad5d95 by @anthony-redFox)

Copy link
Contributor

@johnjbarton johnjbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@johnjbarton johnjbarton merged commit 9eb6436 into karma-runner:master Feb 24, 2020
@karmarunnerbot
Copy link
Member

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants