Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): Report original error message #3415

Merged
merged 1 commit into from Feb 12, 2020
Merged

fix(server): Report original error message #3415

merged 1 commit into from Feb 12, 2020

Conversation

Borewit
Copy link
Contributor

@Borewit Borewit commented Feb 1, 2020

Display original error message of plugins like:

Fixes #3414

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@AppVeyorBot
Copy link

✅ Build karma 2470 completed (commit 3853c8d01d by @Borewit)

@karmarunnerbot
Copy link
Member

✅ Build karma 72 completed (commit 3853c8d01d by @Borewit)

@Borewit
Copy link
Contributor Author

Borewit commented Feb 1, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@karmarunnerbot
Copy link
Member

✅ Build karma 71 completed (commit 3853c8d01d by @Borewit)

@karmarunnerbot
Copy link
Member

✅ Build karma 76 completed (commit d692c3f25c by @Borewit)

@karmarunnerbot
Copy link
Member

✅ Build karma 75 completed (commit d692c3f25c by @Borewit)

@karmarunnerbot
Copy link
Member

✅ Build karma 77 completed (commit 333a842e0a by @Borewit)

@karmarunnerbot
Copy link
Member

✅ Build karma 76 completed (commit 333a842e0a by @Borewit)

@AppVeyorBot
Copy link

✅ Build karma 2474 completed (commit d692c3f25c by @Borewit)

@AppVeyorBot
Copy link

✅ Build karma 2475 completed (commit 333a842e0a by @Borewit)

johnjbarton
johnjbarton suggested changes Feb 6, 2020
View reviewed changes
lib/server.js Outdated Show resolved Hide resolved
@AppVeyorBot
Copy link

❌ Build karma 2476 failed (commit dd46bc0010 by @Borewit)

@karmarunnerbot
Copy link
Member

❌ Build karma 78 failed (commit dd46bc0010 by @Borewit)

@Borewit
fix(server): Report original error message
46a9fd6 
Display original error message of plugins like: karma-browserstack-launcher, karma-cbt-launcher.

Fixes #3414
@AppVeyorBot
Copy link

✅ Build karma 2477 completed (commit 182616b180 by @Borewit)

@karmarunnerbot
Copy link
Member

✅ Build karma 77 completed (commit dd46bc0010 by @Borewit)

@AppVeyorBot
Copy link

✅ Build karma 2478 completed (commit 7bee264933 by @Borewit)

@karmarunnerbot
Copy link
Member

✅ Build karma 79 completed (commit 52fe8a51c3 by @Borewit)

@karmarunnerbot
Copy link
Member

✅ Build karma 78 completed (commit 182616b180 by @Borewit)

@karmarunnerbot
Copy link
Member

✅ Build karma 80 completed (commit 7bee264933 by @Borewit)

@karmarunnerbot
Copy link
Member

✅ Build karma 79 completed (commit 7bee264933 by @Borewit)

@johnjbarton johnjbarton merged commit 79ee331 into karma-runner:master Feb 12, 2020
@trusktr
Copy link

trusktr commented Mar 3, 2020

@johnjbarton @Borewit Are these changes by chanced related to #543 and #1268 in any way?

@trusktr
Copy link

trusktr commented Mar 3, 2020

In particular, regarding those two issues, see my comment at the bottom: #543 (comment)

@Borewit
Copy link
Contributor Author

Borewit commented Mar 3, 2020

Are these changes by chanced related to #543 and #1268 in any way?

I don't think it is the exact same issue.

In this case a message UnhandledRejection was printed to the console, without providing (printing) any further detail.

@Borewit Borewit deleted the display-errer-message branch March 3, 2020 18:02
karmarunnerbot pushed a commit that referenced this pull request Apr 9, 2020
@semantic-release-bot
chore(release): 5.0.0 [skip ci]
1b48637 
# [5.0.0](v4.4.1...v5.0.0) (2020-04-09)

### Bug Fixes

* install semantic-release as a regular dev dependency ([#3455](#3455)) ([1eaf35e](1eaf35e))
* **ci:** echo travis env that gates release after_success ([#3446](#3446)) ([b8b2ed8](b8b2ed8))
* **ci:** poll every 10s to avoid rate limit. ([#3388](#3388)) ([91e7e00](91e7e00))
* **middleware/runner:** handle file list rejections ([#3400](#3400)) ([80febfb](80febfb)), closes [#3396](#3396) [#3396](#3396)
* **server:** cleanup import of the removed method ([#3439](#3439)) ([cb1bcbf](cb1bcbf))
* **server:** createPreprocessor was removed ([#3435](#3435)) ([5c334f5](5c334f5))
* **server:** detection new MS Edge Chromium ([#3440](#3440)) ([7166ce2](7166ce2))
* **server:** replace optimist on yargs lib ([#3451](#3451)) ([ec1e69a](ec1e69a)), closes [#2473](#2473)
* **server:** Report original error message ([#3415](#3415)) ([79ee331](79ee331)), closes [#3414](#3414)

### Code Refactoring

* use native Promise instead of Bluebird ([#3436](#3436)) ([33a069f](33a069f)), closes [/github.com//pull/3060#discussion_r284797390](https://github.com//github.com/karma-runner/karma/pull/3060/issues/discussion_r284797390)

### Continuous Integration

* drop node 8, adopt node 12 ([#3430](#3430)) ([a673aa8](a673aa8))

### Features

* **docs:** document `DEFAULT_LISTEN_ADDR` constant ([#3443](#3443)) ([057d527](057d527)), closes [#2479](#2479)
* **karma-server:** added log to the server.js for uncaught exception ([#3399](#3399)) ([adc6a66](adc6a66))
* **preprocessor:** obey Pattern.isBinary when set ([#3422](#3422)) ([708ae13](708ae13)), closes [#3405](#3405)

### BREAKING CHANGES

* Karma plugins which rely on the fact that Karma uses Bluebird promises may break as Bluebird-specific API is no longer available on Promises returned by the Karma core
* **server:** Deprecated createPreprocessor removed, karma-browserify < 7 version doesn't work
* no more testing on node 8.
@karmarunnerbot
Copy link
Member

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@karronoli karronoli mentioned this pull request Aug 16, 2022
Merged
anthony-redFox pushed a commit to anthony-redFox/karma that referenced this pull request May 16, 2023
@semantic-release-bot @anthony-redFox
chore(release): 5.0.0 [skip ci]
d4e245c 
# [5.0.0](karma-runner/karma@v4.4.1...v5.0.0) (2020-04-09)

### Bug Fixes

* install semantic-release as a regular dev dependency ([karma-runner#3455](karma-runner#3455)) ([1eaf35e](karma-runner@1eaf35e))
* **ci:** echo travis env that gates release after_success ([karma-runner#3446](karma-runner#3446)) ([b8b2ed8](karma-runner@b8b2ed8))
* **ci:** poll every 10s to avoid rate limit. ([karma-runner#3388](karma-runner#3388)) ([91e7e00](karma-runner@91e7e00))
* **middleware/runner:** handle file list rejections ([karma-runner#3400](karma-runner#3400)) ([80febfb](karma-runner@80febfb)), closes [karma-runner#3396](karma-runner#3396) [karma-runner#3396](karma-runner#3396)
* **server:** cleanup import of the removed method ([karma-runner#3439](karma-runner#3439)) ([cb1bcbf](karma-runner@cb1bcbf))
* **server:** createPreprocessor was removed ([karma-runner#3435](karma-runner#3435)) ([5c334f5](karma-runner@5c334f5))
* **server:** detection new MS Edge Chromium ([karma-runner#3440](karma-runner#3440)) ([7166ce2](karma-runner@7166ce2))
* **server:** replace optimist on yargs lib ([karma-runner#3451](karma-runner#3451)) ([ec1e69a](karma-runner@ec1e69a)), closes [karma-runner#2473](karma-runner#2473)
* **server:** Report original error message ([karma-runner#3415](karma-runner#3415)) ([79ee331](karma-runner@79ee331)), closes [karma-runner#3414](karma-runner#3414)

### Code Refactoring

* use native Promise instead of Bluebird ([karma-runner#3436](karma-runner#3436)) ([33a069f](karma-runner@33a069f)), closes [/github.com/karma-runner/pull/3060#discussion_r284797390](https://github.com//github.com/karma-runner/karma/pull/3060/issues/discussion_r284797390)

### Continuous Integration

* drop node 8, adopt node 12 ([karma-runner#3430](karma-runner#3430)) ([a673aa8](karma-runner@a673aa8))

### Features

* **docs:** document `DEFAULT_LISTEN_ADDR` constant ([karma-runner#3443](karma-runner#3443)) ([057d527](karma-runner@057d527)), closes [karma-runner#2479](karma-runner#2479)
* **karma-server:** added log to the server.js for uncaught exception ([karma-runner#3399](karma-runner#3399)) ([adc6a66](karma-runner@adc6a66))
* **preprocessor:** obey Pattern.isBinary when set ([karma-runner#3422](karma-runner#3422)) ([708ae13](karma-runner@708ae13)), closes [karma-runner#3405](karma-runner#3405)

### BREAKING CHANGES

* Karma plugins which rely on the fact that Karma uses Bluebird promises may break as Bluebird-specific API is no longer available on Promises returned by the Karma core
* **server:** Deprecated createPreprocessor removed, karma-browserify < 7 version doesn't work
* no more testing on node 8.
This was referenced Jan 1, 2024
Open
Open
@Omrisnyk Omrisnyk mentioned this pull request Feb 2, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request Feb 11, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request Mar 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trusktr trusktr trusktr left review comments

@johnjbarton johnjbarton johnjbarton approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Original error message is ignored by server
6 participants
@Borewit @googlebot @AppVeyorBot @karmarunnerbot @trusktr @johnjbarton