Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(test): remove @not-jenkins tag for Cucumber tests #3479

Merged
merged 1 commit into from
Apr 20, 2020
Merged

chore(test): remove @not-jenkins tag for Cucumber tests #3479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions cucumber.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@ const options = [
'--require test/e2e/support/env.js',
'--require test/e2e/support/world.js',
'--require test/e2e/step_definitions/core_steps.js',
'--require test/e2e/step_definitions/hooks.js',
'--tags "not @not-jenkins"'
'--require test/e2e/step_definitions/hooks.js'
]

module.exports = {
Expand Down
17 changes: 0 additions & 17 deletions test/e2e/basic.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,23 +19,6 @@ Feature: Basic Testrunner
..
Chrome Headless
"""
@not-jenkins
Scenario: Execute a test in Chrome
Given a configuration with:
"""
files = ['basic/plus.js', 'basic/test.js']
browsers = ['Chrome']
plugins = [
'karma-jasmine',
'karma-chrome-launcher'
]
"""
When I start Karma
Then it passes with:
"""
..
Chrome
"""

Scenario: Execute a test in Firefox
Given a configuration with:
Expand Down
21 changes: 0 additions & 21 deletions test/e2e/runInParent.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,27 +23,6 @@ Feature: runInParent option
..
Chrome Headless
"""
@not-jenkins
Scenario: Execute a test in Chrome
Given a configuration with:
"""
files = ['basic/plus.js', 'basic/test.js']
browsers = ['Chrome']
plugins = [
'karma-jasmine',
'karma-chrome-launcher'
]
client = {
useIframe: false,
runInParent: true
}
"""
When I start Karma
Then it passes with:
"""
..
Chrome
"""

Scenario: Execute a test in Firefox
Given a configuration with:
Expand Down
12 changes: 6 additions & 6 deletions test/e2e/tag.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,12 @@ Feature: JavaScript Tag
.
Firefox
"""
@not-jenkins
Scenario: Execute a test in Chrome with version, without JavaScript tag

Scenario: Execute a test in ChromeHeadless with version, without JavaScript tag
Given a configuration with:
"""
files = ['tag/tag.js', 'tag/test-with-version.js'];
browsers = ['Chrome'];
browsers = ['ChromeHeadlessNoSandbox'];
plugins = [
'karma-jasmine',
'karma-chrome-launcher'
Expand Down Expand Up @@ -53,12 +53,12 @@ Feature: JavaScript Tag
.
Firefox
"""
@not-jenkins
Scenario: Execute a test in Chrome without version, without JavaScript tag

Scenario: Execute a test in ChromeHeadless without version, without JavaScript tag
Given a configuration with:
"""
files = ['tag/tag.js', 'tag/test-without-version.js'];
browsers = ['Chrome'];
browsers = ['ChromeHeadlessNoSandbox'];
plugins = [
'karma-jasmine',
'karma-chrome-launcher'
Expand Down