refactor(test): remove no debug matching option #3504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to filter out [DEBUG] logs as tests are run with logLevel = "warn" by default.
johnjbarton
approved these changes
May 7, 2020
|
It was there from when this test was added in 2013, so hard to say exactly why it was needed. Maybe tests were run with log level = debug at that time. Now tests are run with log level = warn, so it does nothing. Test still checks what it is supposed to check - run fails without client arguments and passes with them. Thus showing that arguments are passed to the browser. |
|
✅ Build karma 261 completed (commit 3944debb8f by @devoto13) |
|
✅ Build karma 260 completed (commit 3944debb8f by @devoto13) |
|
🎉 This PR is included in version 5.0.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
anthony-redFox
pushed a commit
to anthony-redFox/karma
that referenced
this pull request
May 16, 2023
There is no need to filter out [DEBUG] logs as tests are run with logLevel = "warn" by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to filter out [DEBUG] logs as tests are run with logLevel = "warn" by default.