feat: bump socket-io to v3 (wip) #3586

muuvmuuv · 2020-12-15T08:38:32Z

BREAKING CHANGE:

Bump socket-io v2 to v3

Closes: #3569

muuvmuuv · 2020-12-15T08:41:51Z

Would need some help with naming Type and Scope of the commit messages. Think the bump might be chore but should I include the fix in it too? I also thought breaking changes must be prepended with a ! in before the type.

https://github.com/karma-runner/karma/blob/ad820a1d0998f0a81eb1d231e3f9b034d8ff21c6/docs/dev/06-git-commit-msg.md

AppVeyorBot · 2020-12-15T08:42:48Z

✅ Build karma 2790 completed (commit a4498cdb01 by @muuvmuuv)

karmarunnerbot · 2020-12-15T08:43:03Z

✅ Build karma 393 completed (commit a4498cdb01 by @muuvmuuv)

muuvmuuv · 2020-12-15T08:43:17Z

Some tests are locally failing but I really do not know why:

7) Scenario: Completion command help # test/e2e/cli.feature:158
   ✔ Before # test/e2e/step_definitions/hooks.js:3
   ✔ When I execute Karma with arguments: "completion --help" # test/e2e/step_definitions/core_steps.js:57
   ✖ Then the stdout is exactly: # test/e2e/step_definitions/core_steps.js:111
       """
       Karma - Spectacular Test Runner for JavaScript.

       COMPLETION - Bash/ZSH completion for karma.

       Installation:
         karma completion >> ~/.bashrc

       Options:
         --help  Print usage and options.                                     [boolean]
       """
       Error: Expected output to be exactly as above, but got:

       Karma - Spectacular Test Runner for JavaScript.

       COMPLETION - Bash/ZSH completion for karma.

       Installation:
         karma completion >> ~/.bashrc

       Optionen:
         --help  Print usage and options.                                     [boolean]
           at World.<anonymous> (/karma/test/e2e/step_definitions/core_steps.js:118:15)
   ✔ After # test/e2e/step_definitions/hooks.js:7

Test output seems equal.

karmarunnerbot · 2020-12-15T08:47:14Z

✅ Build karma 392 completed (commit a4498cdb01 by @muuvmuuv)

devoto13 · 2020-12-15T12:21:45Z

"Options" vs "Optionen". Maybe related to your locale?

muuvmuuv · 2020-12-15T14:58:46Z

@devoto13 you are right, I have totally overseen that. Anyway to force my locale or tell the tests they should use "en"?

devoto13 · 2020-12-15T17:32:24Z

@muuvmuuv Not sure out of my head, but please send a PR if you figure it out. Ideally force tests to use "en".

johnjbarton

Thanks!

This reverts commit 1b9e1de.

# [6.0.0](v5.2.3...v6.0.0) (2021-01-13) ### Bug Fixes * **ci:** abandon browserstack tests for Safari and IE ([#3615](#3615)) ([04a811d](04a811d)) * **client:** do not reset karmaNavigating in unload handler ([#3591](#3591)) ([4a8178f](4a8178f)), closes [#3482](#3482) * **context:** do not error when karma is navigating ([#3565](#3565)) ([05dc288](05dc288)), closes [#3560](#3560) * **cve:** update ua-parser-js to 0.7.23 to fix CVE-2020-7793 ([#3584](#3584)) ([f819fa8](f819fa8)) * **cve:** update yargs to 16.1.1 to fix cve-2020-7774 in y18n ([#3578](#3578)) ([3fed0bc](3fed0bc)), closes [#3577](#3577) * **deps:** bump socket-io to v3 ([#3586](#3586)) ([1b9e1de](1b9e1de)), closes [#3569](#3569) * **middleware:** catch errors when loading a module ([#3605](#3605)) ([fec972f](fec972f)), closes [#3572](#3572) * **server:** clean up close-server logic ([#3607](#3607)) ([3fca456](3fca456)) * **test:** clear up clearContext ([#3597](#3597)) ([8997b74](8997b74)) * **test:** mark all second connections reconnects ([#3598](#3598)) ([1c9c2de](1c9c2de)) ### Features * **cli:** error out on unexpected options or parameters ([#3589](#3589)) ([603bbc0](603bbc0)) * **client:** update banner with connection, test status, ping times ([#3611](#3611)) ([4bf90f7](4bf90f7)) * **server:** print stack of unhandledrejections ([#3593](#3593)) ([35a5842](35a5842)) * **server:** remove deprecated static methods ([#3595](#3595)) ([1a65bf1](1a65bf1)) * remove support for running dart code in the browser ([#3592](#3592)) ([7a3bd55](7a3bd55)) ### BREAKING CHANGES * **server:** Deprecated `require('karma').server.start()` and `require('karma').Server.start()` variants were removed from the public API. Instead use canonical form: ``` const { Server } = require('karma'); const server = new Server(); server.start(); ``` * **cli:** Karma is more strict and will error out if unknown option or argument is passed to CLI. * Using Karma to run Dart code in the browser is no longer supported. Use your favorite Dart-to-JS compiler instead. `dart` file type has been removed without a replacement. `customFileHandlers` DI token has been removed. Use [`middleware`](http://karma-runner.github.io/5.2/config/configuration-file.html#middleware) to achieve similar functionality. `customScriptTypes` DI token has been removed. It had no effect, so no replacement is provided. * **deps:** Some projects have socket.io tests that are version sensitive.

karmarunnerbot · 2021-01-13T17:47:51Z

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

* fix socket-io deprecated default export BREAKING CHANGE: Some projects have socket.io tests that are version sensitive. Fixes karma-runner#3569

# [6.0.0](karma-runner/karma@v5.2.3...v6.0.0) (2021-01-13) ### Bug Fixes * **ci:** abandon browserstack tests for Safari and IE ([karma-runner#3615](karma-runner#3615)) ([04a811d](karma-runner@04a811d)) * **client:** do not reset karmaNavigating in unload handler ([karma-runner#3591](karma-runner#3591)) ([4a8178f](karma-runner@4a8178f)), closes [karma-runner#3482](karma-runner#3482) * **context:** do not error when karma is navigating ([karma-runner#3565](karma-runner#3565)) ([05dc288](karma-runner@05dc288)), closes [karma-runner#3560](karma-runner#3560) * **cve:** update ua-parser-js to 0.7.23 to fix CVE-2020-7793 ([karma-runner#3584](karma-runner#3584)) ([f819fa8](karma-runner@f819fa8)) * **cve:** update yargs to 16.1.1 to fix cve-2020-7774 in y18n ([karma-runner#3578](karma-runner#3578)) ([3fed0bc](karma-runner@3fed0bc)), closes [karma-runner#3577](karma-runner#3577) * **deps:** bump socket-io to v3 ([karma-runner#3586](karma-runner#3586)) ([1b9e1de](karma-runner@1b9e1de)), closes [karma-runner#3569](karma-runner#3569) * **middleware:** catch errors when loading a module ([karma-runner#3605](karma-runner#3605)) ([fec972f](karma-runner@fec972f)), closes [karma-runner#3572](karma-runner#3572) * **server:** clean up close-server logic ([karma-runner#3607](karma-runner#3607)) ([3fca456](karma-runner@3fca456)) * **test:** clear up clearContext ([karma-runner#3597](karma-runner#3597)) ([8997b74](karma-runner@8997b74)) * **test:** mark all second connections reconnects ([karma-runner#3598](karma-runner#3598)) ([1c9c2de](karma-runner@1c9c2de)) ### Features * **cli:** error out on unexpected options or parameters ([karma-runner#3589](karma-runner#3589)) ([603bbc0](karma-runner@603bbc0)) * **client:** update banner with connection, test status, ping times ([karma-runner#3611](karma-runner#3611)) ([4bf90f7](karma-runner@4bf90f7)) * **server:** print stack of unhandledrejections ([karma-runner#3593](karma-runner#3593)) ([35a5842](karma-runner@35a5842)) * **server:** remove deprecated static methods ([karma-runner#3595](karma-runner#3595)) ([1a65bf1](karma-runner@1a65bf1)) * remove support for running dart code in the browser ([karma-runner#3592](karma-runner#3592)) ([7a3bd55](karma-runner@7a3bd55)) ### BREAKING CHANGES * **server:** Deprecated `require('karma').server.start()` and `require('karma').Server.start()` variants were removed from the public API. Instead use canonical form: ``` const { Server } = require('karma'); const server = new Server(); server.start(); ``` * **cli:** Karma is more strict and will error out if unknown option or argument is passed to CLI. * Using Karma to run Dart code in the browser is no longer supported. Use your favorite Dart-to-JS compiler instead. `dart` file type has been removed without a replacement. `customFileHandlers` DI token has been removed. Use [`middleware`](http://karma-runner.github.io/5.2/config/configuration-file.html#middleware) to achieve similar functionality. `customScriptTypes` DI token has been removed. It had no effect, so no replacement is provided. * **deps:** Some projects have socket.io tests that are version sensitive.

Marvin Heilemann added 2 commits December 15, 2020 09:33

feat: bump socket-io to v3

32e36d2

fix: socket-io deprecated default export

2f0cc0f

johnjbarton approved these changes Dec 15, 2020

View reviewed changes

johnjbarton merged commit 1b9e1de into karma-runner:master Dec 15, 2020

muuvmuuv deleted the bump-socket-io branch December 16, 2020 07:15

devoto13 mentioned this pull request Dec 16, 2020

Potential v7 breaking changes #3503

Open

17 tasks

johnjbarton mentioned this pull request Dec 28, 2020

Travis CI fails on browser-stack tests:client #3606

Closed

johnjbarton added a commit that referenced this pull request Jan 11, 2021

Revert "fix(deps): bump socket-io to v3 (#3586)"

09169af

This reverts commit 1b9e1de.

karmarunnerbot added the released label Jan 13, 2021

namoscato mentioned this pull request Jan 16, 2021

Missing type definitions in Socket.IO 3.x socketio/socket.io#3690

Closed

karronoli mentioned this pull request Aug 16, 2022

Bump karma from ~1.2.0 to ~6.4 in /redpen-server karronoli/redpen#10

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: bump socket-io to v3 (wip) #3586

feat: bump socket-io to v3 (wip) #3586

muuvmuuv commented Dec 15, 2020

muuvmuuv commented Dec 15, 2020

AppVeyorBot commented Dec 15, 2020

karmarunnerbot commented Dec 15, 2020

muuvmuuv commented Dec 15, 2020

karmarunnerbot commented Dec 15, 2020

devoto13 commented Dec 15, 2020

muuvmuuv commented Dec 15, 2020

devoto13 commented Dec 15, 2020

johnjbarton left a comment

karmarunnerbot commented Jan 13, 2021

feat: bump socket-io to v3 (wip) #3586

feat: bump socket-io to v3 (wip) #3586

Conversation

muuvmuuv commented Dec 15, 2020

muuvmuuv commented Dec 15, 2020

AppVeyorBot commented Dec 15, 2020

karmarunnerbot commented Dec 15, 2020

muuvmuuv commented Dec 15, 2020

karmarunnerbot commented Dec 15, 2020

devoto13 commented Dec 15, 2020

muuvmuuv commented Dec 15, 2020

devoto13 commented Dec 15, 2020

johnjbarton left a comment

Choose a reason for hiding this comment

karmarunnerbot commented Jan 13, 2021