Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring modules #61

Merged
merged 36 commits into from
Mar 25, 2016
Merged

Refactoring modules #61

merged 36 commits into from
Mar 25, 2016

Conversation

karma4u101
Copy link
Owner

This PR is connected to #56 (Composing ToolKit) please read the issue report for more information on what this PR implements.

Improvements

This PR currently includes the following improvements:

Initialization

It's no longer necessary to use FoBo.init() in your bootstrap.liftweb.Boot boot method as each FoBo toolkit specified in boot takes care of its own resouce/API set-up.

Test coverage

Improved test coverage. Tests now covers all resource initialization using InitParam (deprecated), ToolKit and Resouce settings. API coverage has not been changed in this PR.

Modules

Below is a list of current (but not final) improvements for each FoBo module.

FoBo (meta module)

ToolKit.Init and Resouce.Init is implemented for:

  • AngularJS usage (Inc. API.Init)

  • FontAwesome

  • Pace

  • Kinetic

  • Google-Code-Prettify

  • JQuery

  • TwBs-Bootstrap3 (Inc. API.Init)

  • Twitter-Bootstrap (Inc. API.Init)

    New tests has been added for the listed toolkit's using Resouce.Init and Toolkit.Init. Tests for InitParam.ToolKit has been updated/re-written.

AngularJS

  • New fobo-angularjs-res and fobo-angularjs-api modules has been added and referenced by fobo-angular.
  • In fobo-angularjs the InitParam.ToolKit usage has been deprecated in favour for using ToolKit.Init (or Resource.Init/API.Init)
  • Tests has been added for AngularJS and AngularJS-Res using Resouce.Init and Toolkit.Init

Pace module

  • The fobo-pace module does now implement the new initiation schema.
  • In fobo-pace the InitParam.ToolKit usage has been deprecated in favour for using ToolKit.Init (or Resource.Init/API.Init)
  • A new fobo-pace-res module has been added and referenced by fobo-pace.
  • Tests has been added for Pace and Pace-Res using Toolkit.Init and Resouce.Init.

Kinetic module

  • The fobo-kineticjs module does now implement the new initiation schema.
  • In fobo-kineticjs the InitParam.ToolKit usage has been deprecated in favour for using ToolKit.Init (or Resource.Init/API.Init)
  • A new fobo-kineticjs-res module has been added and referenced by fobo-kineticjs.
  • Tests has been added for KineticJS and KinteicJS-Res using Toolkit.Init and Resouce.Init.

Font-Awesome

  • The fobo-font-awesome module does now implement the new initiation schema.
  • New fobo-font-awesome-res and fobo-font-awesome-api modules has been added and referenced by fobo-font-awesome.
  • In fobo-font-awesome the InitParam.ToolKit usage has been deprecated in favour for using ToolKit.Init (or Resource.Init/API.Init)
  • Tests has been added for FontAwesome and FontAwesome-Res using Resouce.Init and Toolkit.Init
  • Font-Awesome v4.5.0 has been added to FoBo.

Google-Code-Prettify

  • The fobo-google-code-prettify module does now implement the new initiation schema.
  • In fobo-google-code-prettify the InitParam.ToolKit usage has been deprecated in favour for using ToolKit.Init (or Resource.Init/API.Init)
  • A new fobo-google-code-prettify-res module has been added and referenced by fobo-google-code-prettify.
  • Tests has been added for FoBo-Google-Code-Prettify and FoBo-Google-Code-Prettify-Res using Toolkit.Init and Resouce.Init.

JQuery

  • The fobo-jquery module does now implement the new initiation schema.
  • In fobo-jquery the InitParam.ToolKit usage has been deprecated in favour for using ToolKit.Init (or Resource.Init/API.Init)
  • A new fobo-jquery-res module has been added and referenced by fobo-jquery.
  • Tests has been added for FoBo-JQuery and FoBo-JQuery-Res using Toolkit.Init and Resouce.Init.

TwBs-Bootstrap3

  • The fobo-twbs-boostrap3 module does now implement the new initiation schema.
  • New fobo-twbs-boostrap3-res and fobo-twbs-boostrap3-api modules has been added and referenced by fobo-twbs-boostrap3.
  • In fobo-twbs-boostrap3 the InitParam.ToolKit usage has been deprecated in favour for using ToolKit.Init (or Resource.Init/API.Init)
  • Tests has been added for TwBs-Bootstrap3 and TwBs-Bootstrap3-Res using Toolkit.Init and Resouce.Init.

Twitter-Bootstrap

  • The fobo-twitter-bootstrap module does now implement the new initiation schema.
  • New fobo-twitter-bootstrap-res and fobo-twitter-bootstrap-api modules has been added and referenced by fobo-twitter-bootstrap.
  • In fobo-twitter-bootstrap the InitParam.ToolKit usage has been deprecated in favour for using ToolKit.Init (or Resource.Init/API.Init)
  • Tests has been added for Twitter-Bootstrap and Twitter-Bootstrap-Res using Toolkit.Init and Resouce.Init.

Deprecations

v1.3 deprecations or older is removed.

Removed

  • AngularJS1211 and AngularJS1211i18n resources (as advised use AngularJS1219 or newer)
  • JQuery1110 and JQuery1111 (deprecated sins v1.3, v1.4)

Bugfixes

the fobo-pace module as a resouce reference. Implementing the new
initiation schema and deprecating the "InitParam" usage.
@karma4u101 karma4u101 merged commit 6157d07 into develop Mar 25, 2016
@karma4u101 karma4u101 changed the title Refactoring modules Refactoring modules Mar 25, 2016
@karma4u101 karma4u101 deleted the ref_mod branch March 25, 2016 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant