Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change script path to mimic lift jquery path #4

Closed
karma4u101 opened this issue Jul 1, 2012 · 8 comments
Closed

Change script path to mimic lift jquery path #4

karma4u101 opened this issue Jul 1, 2012 · 8 comments

Comments

@karma4u101
Copy link
Owner

This will make the transaction to the module even less painful for those who have used the Lift included jquery as all the script paths will be the same.
The only problem with this is that if user do not take care of removing the lift jquery init (as long as it exsists) it will probably be the one used (and then with maybe with a different version)

@fmpwizard
Copy link

so, what's the correct path to use?

with latest lift 2.5, in boot I have:

LiftRules.jsArtifacts = JQueryArtifacts

which disables the rewrite to jquery 1.3.x. But setting:

JQueryModule.InitParam.JQuery=JQueryModule.JQuery172
JQueryModule.init()

does not add jquery to the classpath

Thanks

@fmpwizard
Copy link

I did try lift 2.4 and

"net.liftmodules"   %% "lift-jquery-module" % (liftVersion + "-1.0"),

and then using /classpath/jquery.js

did return the jQuery 1.7.2 So maybe we just need a newer snapshot on sonatype (or maybe a release for 2.5)

@karma4u101
Copy link
Owner Author

Ok to make sure i will push and build new snapshots
Den 7 jul 2012 06:25 skrev "Diego Medina" <
reply@reply.github.com

:

I did try lift 2.4 and

"net.liftmodules"   %% "lift-jquery-module" % (liftVersion + "-1.0"),

and then using /classpath/jquery.js

did return the jQuery 1.7.2 So maybe we just need a newer snapshot on
sonatype (or maybe a release for 2.5)


Reply to this email directly or view it on GitHub:

#4 (comment)

@karma4u101
Copy link
Owner Author

There are now new 1.0-SNAPSHOTS available
I hope this helps I noticed yesterday that I had not pushed the 172
jquery script and all my testing has been on local comp.
They are built as I writ now. I am of for a weekend trip and will be on
train for a few hours so I hope this build dose not fail on jenkins.

best regards
Peter Petersson

On 07/07/2012 06:25 AM, Diego Medina wrote:

I did try lift 2.4 and

 "net.liftmodules"   %% "lift-jquery-module" % (liftVersion + "-1.0"),

and then using /classpath/jquery.js

did return the jQuery 1.7.2 So maybe we just need a newer snapshot on sonatype (or maybe a release for 2.5)


Reply to this email directly or view it on GitHub:
#4 (comment)

@karma4u101
Copy link
Owner Author

You could try with 171 for now if that dose not work, we have a problem ;)
best regards
Peter

On 07/07/2012 06:25 AM, Diego Medina wrote:

I did try lift 2.4 and

 "net.liftmodules"   %% "lift-jquery-module" % (liftVersion + "-1.0"),

and then using /classpath/jquery.js

did return the jQuery 1.7.2 So maybe we just need a newer snapshot on sonatype (or maybe a release for 2.5)


Reply to this email directly or view it on GitHub:
#4 (comment)

@karma4u101
Copy link
Owner Author

New snapshots is available, let me know how it goes.
/Peter

On 07/07/2012 05:07 AM, Diego Medina wrote:

so, what's the correct path to use?

with latest lift 2.5, in boot I have:

 LiftRules.jsArtifacts = JQueryArtifacts

which disables the rewrite to jquery 1.3.x. But setting:

 JQueryModule.InitParam.JQuery=JQueryModule.JQuery172
 JQueryModule.init()

does not add jquery to the classpath

Thanks


Reply to this email directly or view it on GitHub:
#4 (comment)

@fmpwizard
Copy link

It worked! Thanks! and enjoy your weekend trip.

On Sat, Jul 7, 2012 at 12:50 AM, Peter Petersson
reply@reply.github.com
wrote:

New snapshots is available, let me know how it goes.
/Peter

On 07/07/2012 05:07 AM, Diego Medina wrote:

so, what's the correct path to use?

with latest lift 2.5, in boot I have:

 LiftRules.jsArtifacts = JQueryArtifacts

which disables the rewrite to jquery 1.3.x. But setting:

 JQueryModule.InitParam.JQuery=JQueryModule.JQuery172
 JQueryModule.init()

does not add jquery to the classpath

Thanks


Reply to this email directly or view it on GitHub:
#4 (comment)


Reply to this email directly or view it on GitHub:
#4 (comment)

Diego Medina
Lift/Scala Developer
diego@fmpwizard.com
http://www.fmpwizard.com

@karma4u101
Copy link
Owner Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants