Merge pull request #4492 from jwcesign/VarDeclarations

cleanup: enable revive(var-declaration rule) checking

.golangci.yml

@@ -79,6 +79,7 @@ linters-settings:
       - name: dot-imports
       - name: errorf
       - name: exported
+      - name: var-declaration
   staticcheck:
     checks:
       - all

pkg/controllers/federatedhpa/federatedhpa_controller.go

@@ -75,7 +75,7 @@ var (
 	// errSpec is used to determine if the error comes from the spec of HPA object in reconcileAutoscaler.
 	// All such errors should have this error as a root error so that the upstream function can distinguish spec errors from internal errors.
 	// e.g., fmt.Errorf("invalid spec%w", errSpec)
-	errSpec error = errors.New("")
+	errSpec = errors.New("")
 )
 
 // FHPAController is to sync FederatedHPA.