New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup: enable revive(var-declaration rule) checking #4492
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4492 +/- ##
=======================================
Coverage 51.86% 51.87%
=======================================
Files 243 243
Lines 24183 24183
=======================================
+ Hits 12543 12544 +1
+ Misses 10958 10957 -1
Partials 682 682
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
You might need to resolve the conflict. |
7c22e69
to
9b805cf
Compare
conflict again. |
Signed-off-by: jwcesign <jwcesign@gmail.com>
9b805cf
to
669a311
Compare
669a311
to
367db18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
cleanup: enable revive(var-declaration rule) checking
Which issue(s) this PR fixes:
Part of #4490
Special notes for your reviewer:
none
Does this PR introduce a user-facing change?: