Fix `karmadactl init` can not read KUBECONFIG environment variable issue #1437

lonelyCZ · 2022-03-07T04:09:50Z

Signed-off-by: lonelyCZ 531187475@qq.com

What type of PR is this?
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #1430

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmadactl`: Fixed `init` can not read KUBECONFIG environment variable issue.

/cc @RainbowMango @XiShanYongYe-Chang @prodanlabs

lonelyCZ · 2022-03-07T04:53:13Z

/retest

RainbowMango · 2022-03-07T06:14:48Z

@huone1 @XiShanYongYe-Chang
https://github.com/karmada-io/karmada/runs/5443201929?check_suite_focus=true

OverridePolicy with nil resourceSelectors
/home/runner/work/karmada/karmada/test/e2e/overridepolicy_test.go:235
  Deployment override testing
  /home/runner/work/karmada/karmada/test/e2e/overridepolicy_test.go:236
    deployment imageOverride testing
    /home/runner/work/karmada/karmada/test/e2e/overridepolicy_test.go:281
------------------------------
failover testing Deployment propagation testing 
  deployment failover testing
  /home/runner/work/karmada/karmada/test/e2e/failover_test.go:62
STEP: Creating PropagationPolicy(karmadatest-hvd/deploy-rwd)
STEP: Creating Deployment(karmadatest-hvd/deploy-rwd)
I0307 04:43:31.529947   37166 deployment.go:124] The ResourceBinding(karmadatest-hvd/deploy-rwd-deployment) schedule result is: member1
STEP: set one cluster condition status to false
I0307 04:43:31.530207   37166 failover_test.go:73] Set cluster member1 to disable.
STEP: check whether deployment of failed cluster is rescheduled to other available cluster
I0307 04:45:06.912277   37166 deployment.go:114] The ResourceBinding(karmadatest-hvd/deploy-rwd-deployment) hasn't been scheduled.
I0307 04:45:11.921584   37166 deployment.go:114] The ResourceBinding(karmadatest-hvd/deploy-rwd-deployment) hasn't been scheduled.
I0307 04:45:16.929873   37166 deployment.go:114] The ResourceBinding(karmadatest-hvd/deploy-rwd-deployment) hasn't been scheduled.
I0307 04:45:21.945206   37166 deployment.go:114] The ResourceBinding(karmadatest-hvd/deploy-rwd-deployment) hasn't been scheduled.
I0307 04:45:26.96[1151](https://github.com/karmada-io/karmada/runs/5443201929?check_suite_focus=true#step:5:1151)   37166 deployment.go:114] The ResourceBinding(karmadatest-hvd/deploy-rwd-deployment) hasn't been scheduled.
I0307 04:45:31.970542   37166 deployment.go:114] The ResourceBinding(karmadatest-hvd/deploy-rwd-deployment) hasn't been scheduled.
I0307 04:45:36.991220   37166 deployment.go:114] The ResourceBinding(karmadatest-hvd/deploy-rwd-deployment) hasn't been scheduled.
I0307 04:45:42.000291   37166 deployment.go:114] The ResourceBinding(karmadatest-hvd/deploy-rwd-deployment) hasn't been scheduled.
I0307 04:45:47.008024   37166 deployment.go:114] The ResourceBinding(karmadatest-hvd/deploy-rwd-deployment) hasn't been scheduled.
I0307 04:45:52.014640   37166 deployment.go:114] The ResourceBinding(karmadatest-hvd/deploy-rwd-deployment) hasn't been scheduled.
I0307 04:45:57.023043   37166 deployment.go:114] The ResourceBinding(karmadatest-hvd/deploy-rwd-deployment) hasn't been scheduled.
I0307 04:46:02.030664   37166 deployment.go:114] The ResourceBinding(karmadatest-hvd/deploy-rwd-deployment) hasn't been scheduled.
I0307 04:46:07.039217   37166 deployment.go:114] The ResourceBinding(karmadatest-hvd/deploy-rwd-deployment) hasn't been scheduled.
I0307 04:46:12.055902   37166 deployment.go:114] The ResourceBinding(karmadatest-hvd/deploy-rwd-deployment) hasn't been scheduled.
I0307 04:46:17.066281   37166 deployment.go:114] The ResourceBinding(karmadatest-hvd/deploy-rwd-deployment) hasn't been scheduled.
I0307 04:46:22.074774   37166 deployment.go:114] The ResourceBinding(karmadatest-hvd/deploy-rwd-deployment) hasn't been scheduled.
I0307 04:46:27.087882   37166 deployment.go:124] The ResourceBinding(karmadatest-hvd/deploy-rwd-deployment) schedule result is: member1

• Failure [180.624 seconds]
failover testing
/home/runner/work/karmada/karmada/test/e2e/failover_test.go:27
  Deployment propagation testing
  /home/runner/work/karmada/karmada/test/e2e/failover_test.go:28
    deployment failover testing [It]
    /home/runner/work/karmada/karmada/test/e2e/failover_test.go:62

    Expected
        <bool>: true
    to be false

    /home/runner/work/karmada/karmada/test/e2e/failover_test.go:93
------------------------------
S

Summarizing 1 Failure:

[Fail] failover testing Deployment propagation testing [It] deployment failover testing 
/home/runner/work/karmada/karmada/test/e2e/failover_test.go:93

Ran 40 of 41 Specs in 927.083 seconds
FAIL! -- 39 Passed | 1 Failed | 0 Pending | 1 Skipped

XiShanYongYe-Chang · 2022-03-08T09:10:50Z

Hi @lonelyCZ, can you rebase the latest code, we have solved the CI failed.

XiShanYongYe-Chang

/lgtm

This pr will be conflict with #1455

lonelyCZ · 2022-03-10T08:20:27Z

This pr will be conflict with #1455

Got it. Thanks. :)

RainbowMango · 2022-03-10T08:23:03Z

Please add a release note on the PR description.

By the way, should we cherry-pick this to release branches?

cc @prodanlabs might want to know what we are going to do.

prodanlabs · 2022-03-10T08:47:34Z

Please add a release note on the PR description.

By the way, should we cherry-pick this to release branches?

cc @prodanlabs might want to know what we are going to do.

I'll take a look when I'm free, I have no problem here. thx

lonelyCZ · 2022-03-10T10:33:43Z

Do I need to cheery-pick this now? @RainbowMango

RainbowMango · 2022-03-10T10:42:31Z

Do I need to cheery-pick this now? @RainbowMango

Hold on until this is merged to master. I haven't looked at this yet, will do it ASAP.

RainbowMango · 2022-03-11T07:27:52Z

pkg/karmadactl/cmdinit/kubernetes/deploy.go

+	// check config path of host kubernetes cluster
+	env := os.Getenv("KUBECONFIG")
+	if env != "" {
+		i.KubeConfig = env
+	}


Does this mean KUBECONFIG environment would override --kubeconfig?

The kubectl get config according to following rules, that we can't violate :

Via the command-line flag --kubeconfig

Via the KUBECONFIG environment variable

In your home directory as ~/.kube/config

Ok, I will fix it as these rules.

Signed-off-by: lonelyCZ <531187475@qq.com>

lonelyCZ · 2022-03-11T10:13:04Z

Abide by the rules and the conflict has been fixed.

RainbowMango · 2022-03-14T07:57:11Z

cc @XiShanYongYe-Chang

RainbowMango

/approve

Leave LGTM to @XiShanYongYe-Chang

retitle Fix karmadactl init can not read KUBECONFIG environment variable issue

karmada-bot · 2022-03-14T08:07:05Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

RainbowMango · 2022-03-14T08:07:28Z

/retitle Fix karmadactl init can not read KUBECONFIG environment variable issue

XiShanYongYe-Chang

/lgtm

RainbowMango · 2022-03-14T08:25:52Z

Hi @lonelyCZ Would you like cherry-pick this patch to release-1.0 and release-1.1 branch?
You can do that by this cherry-pick script.

lonelyCZ · 2022-03-14T08:28:11Z

Yes, thanks. I will try to do it.

…-upstream-release-1.1 Automated cherry pick of #1437: fix `karmadactl init` can not read KUBECONFIG environment variable issue

…-upstream-release-1.0 Automated cherry pick of #1437: fix `karmadactl init` can not read KUBECONFIG environment variable issue

karmada-bot requested review from prodanlabs, RainbowMango and XiShanYongYe-Chang March 7, 2022 04:09

karmada-bot added kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 7, 2022

lonelyCZ force-pushed the init-kubeconfig branch from c452a6e to 4b27bd8 Compare March 8, 2022 10:07

XiShanYongYe-Chang reviewed Mar 10, 2022

View reviewed changes

karmada-bot assigned XiShanYongYe-Chang Mar 10, 2022

karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2022

karmada-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 10, 2022

RainbowMango reviewed Mar 11, 2022

View reviewed changes

Fix bug: [karmadactl init] can not read KUBECONFIG environment variable

d3ac601

Signed-off-by: lonelyCZ <531187475@qq.com>

lonelyCZ force-pushed the init-kubeconfig branch from 4b27bd8 to d3ac601 Compare March 11, 2022 10:08

karmada-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 11, 2022

RainbowMango approved these changes Mar 14, 2022

View reviewed changes

karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2022

karmada-bot changed the title ~~Fix bug: [karmadactl init] can not read KUBECONFIG environment variable~~ Fix karmadactl init can not read KUBECONFIG environment variable issue Mar 14, 2022

XiShanYongYe-Chang reviewed Mar 14, 2022

View reviewed changes

karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2022

karmada-bot merged commit 0961767 into karmada-io:master Mar 14, 2022

This was referenced Mar 15, 2022

Automated cherry pick of #1437: fix karmadactl init can not read KUBECONFIG environment variable issue #1482

Merged

Automated cherry pick of #1437: fix karmadactl init can not read KUBECONFIG environment variable issue #1483

Merged

karmada-bot added a commit that referenced this pull request Mar 15, 2022

Merge pull request #1483 from lonelyCZ/automated-cherry-pick-of-#1437…

f7b0051

…-upstream-release-1.1 Automated cherry pick of #1437: fix `karmadactl init` can not read KUBECONFIG environment variable issue

karmada-bot added a commit that referenced this pull request Mar 15, 2022

Merge pull request #1482 from lonelyCZ/automated-cherry-pick-of-#1437…

f5c0940

…-upstream-release-1.0 Automated cherry pick of #1437: fix `karmadactl init` can not read KUBECONFIG environment variable issue

lonelyCZ deleted the init-kubeconfig branch July 11, 2022 07:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix `karmadactl init` can not read KUBECONFIG environment variable issue #1437

Fix `karmadactl init` can not read KUBECONFIG environment variable issue #1437

lonelyCZ commented Mar 7, 2022 •

edited by RainbowMango

lonelyCZ commented Mar 7, 2022

RainbowMango commented Mar 7, 2022

XiShanYongYe-Chang commented Mar 8, 2022

XiShanYongYe-Chang left a comment

lonelyCZ commented Mar 10, 2022

RainbowMango commented Mar 10, 2022

prodanlabs commented Mar 10, 2022

lonelyCZ commented Mar 10, 2022

RainbowMango commented Mar 10, 2022

RainbowMango Mar 11, 2022

lonelyCZ Mar 11, 2022

lonelyCZ commented Mar 11, 2022

RainbowMango commented Mar 14, 2022

RainbowMango left a comment

karmada-bot commented Mar 14, 2022

RainbowMango commented Mar 14, 2022

XiShanYongYe-Chang left a comment

RainbowMango commented Mar 14, 2022

lonelyCZ commented Mar 14, 2022

Fix karmadactl init can not read KUBECONFIG environment variable issue #1437

Fix karmadactl init can not read KUBECONFIG environment variable issue #1437

Conversation

lonelyCZ commented Mar 7, 2022 • edited by RainbowMango

lonelyCZ commented Mar 7, 2022

RainbowMango commented Mar 7, 2022

XiShanYongYe-Chang commented Mar 8, 2022

XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

lonelyCZ commented Mar 10, 2022

RainbowMango commented Mar 10, 2022

prodanlabs commented Mar 10, 2022

lonelyCZ commented Mar 10, 2022

RainbowMango commented Mar 10, 2022

RainbowMango Mar 11, 2022

Choose a reason for hiding this comment

lonelyCZ Mar 11, 2022

Choose a reason for hiding this comment

lonelyCZ commented Mar 11, 2022

RainbowMango commented Mar 14, 2022

RainbowMango left a comment

Choose a reason for hiding this comment

karmada-bot commented Mar 14, 2022

RainbowMango commented Mar 14, 2022

XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

RainbowMango commented Mar 14, 2022

lonelyCZ commented Mar 14, 2022

Fix `karmadactl init` can not read KUBECONFIG environment variable issue #1437

Fix `karmadactl init` can not read KUBECONFIG environment variable issue #1437

lonelyCZ commented Mar 7, 2022 •

edited by RainbowMango