-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delete the karmada data directory before installing with init #1455
Conversation
24c6184
to
6214048
Compare
Signed-off-by: prodan <pengshihaoren@gmail.com>
6214048
to
38c2eb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I test it on my side, it works ok 👍
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…1455-upstream-release-1.1 Automated cherry pick of #1455: delete the karmada data directory before installing with init
…1455-upstream-release-1.0 Automated cherry pick of #1455: delete the karmada data directory before installing with init
Signed-off-by: prodan pengshihaoren@gmail.com
What type of PR is this?
/kind feature
What this PR does / why we need it:
When the current host uses init to install karmada multiple times, the installation fails because the data directory of karmada is not empty.
Which issue(s) this PR fixes:
Fixes #1454
Fixes #1467
Special notes for your reviewer:
Does this PR introduce a user-facing change?: