Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete the karmada data directory before installing with init #1455

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

prodanlabs
Copy link
Member

@prodanlabs prodanlabs commented Mar 8, 2022

Signed-off-by: prodan pengshihaoren@gmail.com

What type of PR is this?
/kind feature

What this PR does / why we need it:
When the current host uses init to install karmada multiple times, the installation fails because the data directory of karmada is not empty.
Which issue(s) this PR fixes:
Fixes #1454
Fixes #1467

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmadactl`: Fixed `init` failure due to data path not clean issue.

@karmada-bot karmada-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Mar 8, 2022
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 8, 2022
Signed-off-by: prodan <pengshihaoren@gmail.com>
@prodanlabs
Copy link
Member Author

/cc @XiShanYongYe-Chang

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I test it on my side, it works ok 👍

/lgtm

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2022
@karmada-bot karmada-bot merged commit 43748ff into karmada-io:master Mar 11, 2022
karmada-bot added a commit that referenced this pull request Mar 14, 2022
…1455-upstream-release-1.1

Automated cherry pick of #1455: delete the karmada data directory before installing with init
karmada-bot added a commit that referenced this pull request Mar 14, 2022
…1455-upstream-release-1.0

Automated cherry pick of #1455: delete the karmada data directory before installing with init
@prodanlabs prodanlabs deleted the karmadactl-feature branch June 10, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
4 participants