New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: update binding status when work's applied condition status changed #1513
Conversation
…tus changed Signed-off-by: lihanbo <lihanbo2@huawei.com>
To reproduce:
step2: create a nodeport service using
step3: create propagation policy:
step4: update nodePort of karmada service to
binding status:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/cc @RainbowMango
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
@mrlihanbo
Please help cherry-pick this patch to both release-1.0
and release-1.1
.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…3-upstream-release-1.1 Automated cherry pick of #1513: bugfix: aggregate status to binding when work's applied condition status changed
…3-upstream-release-1.0 Automated cherry pick of #1513: bugfix: aggregate status to binding when work's applied condition status changed
Signed-off-by: lihanbo lihanbo2@huawei.com
What type of PR is this?
/kind bug
What this PR does / why we need it:
When execution controller update resource failed, the work's fully applied condition will be set to
False
, but theManifestStatuses
won't be changed(as updated failed). Under this circumstance,binding controller also need to aggregate work status.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: