Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: update binding status when work's applied condition status changed #1513

Merged
merged 1 commit into from Mar 23, 2022
Merged

bugfix: update binding status when work's applied condition status changed #1513

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/controllers/binding/common.go
View file
Open in desktop
Expand Up @@ -27,18 +27,18 @@ var workPredicateFn = builder.WithPredicates(predicate.Funcs{
return false
},
UpdateFunc: func(e event.UpdateEvent) bool {
var statusesOld, statusesNew []workv1alpha1.ManifestStatus
var statusesOld, statusesNew workv1alpha1.WorkStatus

switch oldWork := e.ObjectOld.(type) {
case *workv1alpha1.Work:
statusesOld = oldWork.Status.ManifestStatuses
statusesOld = oldWork.Status
default:
return false
}

switch newWork := e.ObjectNew.(type) {
case *workv1alpha1.Work:
statusesNew = newWork.Status.ManifestStatuses
statusesNew = newWork.Status
default:
return false
}
Expand Down