Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed a panic which due to nil annotation during promote resources to Karmada #1759

Merged
merged 1 commit into from
May 11, 2022
Merged

fixed a panic which due to nil annotation during promote resources to Karmada #1759

merged 1 commit into from
May 11, 2022

Conversation

duanmengkk
Copy link
Member

@duanmengkk duanmengkk commented May 10, 2022 •
edited by RainbowMango
Loading

…d overwrite annotation

Signed-off-by: duanmeng duanmeng_yewu@cmss.chinamobile.com

What type of PR is this?
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:
Partof #1758

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmadactl: fixed a panic which due to nil annotation during promote resources to Karmada.`

@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label May 10, 2022
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 10, 2022
@duanmengkk duanmengkk changed the title fix empty anannotation which result to null-pointer exception when ad… WIP:fix empty anannotation which result to null-pointer exception when ad… May 10, 2022
@karmada-bot karmada-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 10, 2022
@duanmengkk duanmengkk changed the title WIP:fix empty anannotation which result to null-pointer exception when ad… fix empty anannotation which result to null-pointer exception when ad… May 10, 2022
@karmada-bot karmada-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 10, 2022
@duanmengkk
Copy link
Member Author

duanmengkk commented May 10, 2022 •
edited
Loading

/cc @lonelyCZ As mentioned in the meeting,i will fix these bugs one by one with multiple PRs.

@karmada-bot karmada-bot added the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label May 10, 2022
@karmada-bot karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 10, 2022
@duanmengkk
fix empty anannotation which result to null-pointer exception when ad…
9ea26cc 
…d overwrite annotation

Signed-off-by: duanmeng <duanmeng_yewu@cmss.chinamobile.com>
@karmada-bot karmada-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 10, 2022
RainbowMango
RainbowMango approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Approve first for not block this and leave LGTM to @lonelyCZ

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2022
@RainbowMango
Copy link
Member

Hi @duanmengkk Thanks for doing this.
Just a reminder that you are sending PR from your master branch, it's ok but it might involve some trouble for you if you want to work on different PRs on the same time.
Here is the guideline that might help.
https://github.com/karmada-io/karmada/blob/master/docs/contributors/guide/github-workflow.md

@RainbowMango
Copy link
Member

/retitle fixed a panic which due to nil annotation during promote resources to Karmada

@karmada-bot karmada-bot changed the title fix empty anannotation which result to null-pointer exception when ad… fixed a panic which due to nil annotation during promote resources to Karmada May 11, 2022
@duanmengkk duanmengkk mentioned this pull request May 11, 2022
Merged
@lonelyCZ
Copy link
Member

It works fine, thanks @duanmengkk

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2022
@karmada-bot karmada-bot merged commit da78076 into karmada-io:master May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RainbowMango RainbowMango RainbowMango approved these changes

@lonelyCZ lonelyCZ Awaiting requested review from lonelyCZ

@XiShanYongYe-Chang XiShanYongYe-Chang Awaiting requested review from XiShanYongYe-Chang

Assignees

@lonelyCZ lonelyCZ

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@duanmengkk @karmada-bot @RainbowMango @lonelyCZ