fixed a bug where not-namespaced resource could not be promoted #1766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmada-bot
added
do-not-merge/contains-merge-commits
duanmengkk
force-pushed
the
feature_globalResource
branch
from
d608753
to
5ebcf3b
Compare
karmada-bot
removed
the
do-not-merge/contains-merge-commits
|
Have you tested it? |
test fine in goland,i will do a complete test in linux.But some errors occurs after the PR #1740 ,I'm trying to figure it out |
duanmengkk
changed the title
karmada-bot
added
do-not-merge/work-in-progress
duanmengkk
force-pushed
the
feature_globalResource
branch
from
8edbaf4
to
b9449c0
Compare
karmada-bot
added
do-not-merge/contains-merge-commits
duanmengkk
force-pushed
the
feature_globalResource
branch
from
9f5724c
to
cdb94ed
Compare
karmada-bot
removed
the
do-not-merge/contains-merge-commits
duanmengkk
changed the title
karmada-bot
removed
the
do-not-merge/work-in-progress
|
/cc @lonelyCZ Take a look,i have a mistake before.It works fine in my env now |
karmada-bot
added
the
do-not-merge/contains-merge-commits
duanmengkk
changed the title
karmada-bot
added
the
do-not-merge/work-in-progress
Signed-off-by: duanmeng <duanmeng_yewu@cmss.chinamobile.com>
duanmengkk
force-pushed
the
feature_globalResource
branch
from
398c938
to
e7ba433
Compare
karmada-bot
removed
the
do-not-merge/contains-merge-commits
duanmengkk
changed the title
karmada-bot
removed
the
do-not-merge/work-in-progress
|
Great, test is fine. Thanks @duanmengkk /lgtm |
|
/approve I added release note to the PR description by the way. @lonelyCZ Do you think this patch should cherry-pick to release branches? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
|
Yes，it is necessary, including #1759 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1758
Special notes for your reviewer:
Does this PR introduce a user-facing change?: