avoid joining the same cluster repeatedly #2369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmada-bot
added
the
size/M
yy158775
changed the title
yy158775
changed the title
yy158775
force-pushed
the
id_join
branch
2 times, most recently
from
b63ed62
to
765635f
Compare
yy158775
force-pushed
the
id_join
branch
4 times, most recently
from
2f81f7a
to
da89022
Compare
cmd/agent/app/agent.go
Outdated
| } | ||
|
|
||
| if !ok { | ||
| return fmt.Errorf("cluster(id):%s already exist", id) |
There was a problem hiding this comment.
error: failed to create cluster(member4) object. error: cluster(id:fc1c4701-34c9-4a4b-afc2-296ecefe0c2d) already exist
This log doesn't clear enough for users to understand what happened.
The log should be The same cluster has been registered with name xxxx
yy158775
force-pushed
the
id_join
branch
2 times, most recently
from
13df04e
to
d879d24
Compare
Signed-off-by: yy158775 <1584616775@qq.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yy158775 1584616775@qq.com
What type of PR is this?
/kind bug
What this PR does / why we need it:
prevent the same cluster repeating to join karmada.
Which issue(s) this PR fixes:
Fixes #1351
Special notes for your reviewer:
Does this PR introduce a user-facing change?: