add default interpreter for interpretHealth #2370
Conversation
karmada-bot
added
the
kind/feature
karmada-bot
added
the
size/L
| return false, err | ||
| } | ||
|
|
||
| if replicaSet.Generation == replicaSet.Status.ObservedGeneration { |
There was a problem hiding this comment.
We can use guard code here, just like:
if replicaSet.Generation != replicaSet.Status.ObservedGeneration {
return false, nil
}
Same as bellow.
| healthy := pvc.Status.Phase == corev1.ClaimBound | ||
| return healthy, nil |
There was a problem hiding this comment.
How about this:
return pvc.Status.Phase == corev1.ClaimBound, nil| @@ -211,3 +212,314 @@ func Test_interpretStatefulSetHealth(t *testing.T) { | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
| func Test_interpretReplicaSetHealth(t *testing.T) { | |||
There was a problem hiding this comment.
The case for determining the replicas is missing.
| { | ||
| name: "failed convert to ReplicaSet object", | ||
| object: &unstructured.Unstructured{ | ||
| Object: map[string]interface{}{ | ||
| "spec": "format error", | ||
| "status": "format error", | ||
| }, | ||
| }, | ||
| want: false, | ||
| wantErr: true, | ||
| }, |
There was a problem hiding this comment.
I see similar judgments in each test case. Is it possible to consider testing method ConvertToTypedObject so that similar test cases can be omitted?
If this is feasible, you can submit a separate pr to test method ConvertToTypedObject.
|
/assign |
Signed-off-by: zhuwint <zhuwentao15@huawei.com>
zhuwint
force-pushed
the
dev-defaultinterpreter
branch
from
f5b38e7
to
989fb49
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango, XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
/kind feature
What this PR does / why we need it:
add default resource interpreter for interpretHealth
Which issue(s) this PR fixes:
Part of #2354
Special notes for your reviewer:
The method for health check is referred to https://github.com/jessesuen/argo-cd/blob/37a58fb9f1a2d7e20fe8e37a93ffa2e66b0eb9c7/util/health/health.go
Does this PR introduce a user-facing change?:
NONE