Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perceiving the health status of cluster scheduling results in graceful evictions #2425

Conversation

XiShanYongYe-Chang
Copy link
Member

Signed-off-by: changzhen changzhen5@huawei.com

What type of PR is this?

/kind feature

What this PR does / why we need it:

When we evict workload replicas from the failover cluster in the ResourceBinding/ClusterResourceBinding, we need to perceive the health status of the current scheduling result of the binding to make the eviction more graceful. If the status is healthy, we can evict workload replicas directly. Otherwise, wait for the timeout period.

Which issue(s) this PR fixes:
Part of #2281

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE(include in graceful eviction feature)

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 25, 2022
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 25, 2022
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the preceiving-health-in-graceful-eviction branch from 35adaad to 6045cfc Compare August 25, 2022 03:05
@karmada-bot karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 25, 2022
@XiShanYongYe-Chang
Copy link
Member Author

/cc @RainbowMango @Garrybest

@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the preceiving-health-in-graceful-eviction branch from 6045cfc to f4bf7fe Compare August 26, 2022 01:13
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2022
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2022
@RainbowMango
Copy link
Member

please rebase your code (#2428 has been merged)

…l evictions

Signed-off-by: changzhen <changzhen5@huawei.com>
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the preceiving-health-in-graceful-eviction branch from f4bf7fe to e90edb2 Compare August 26, 2022 07:14
@karmada-bot karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2022
@RainbowMango
Copy link
Member

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2022
@karmada-bot karmada-bot merged commit ad7ca1f into karmada-io:master Aug 26, 2022
@XiShanYongYe-Chang XiShanYongYe-Chang deleted the preceiving-health-in-graceful-eviction branch August 31, 2022 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants