Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] fix error of reflectStatus failed when call resourceInterpreter #2428

Merged

Conversation

XiShanYongYe-Chang
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang commented Aug 26, 2022

Signed-off-by: changzhen changzhen5@huawei.com

What type of PR is this?

/kind failing-test
/kind bug

What this PR does / why we need it:

In the pr #2425 we encountered a CI error https://github.com/karmada-io/karmada/runs/8028253698?check_suite_focus=true and the component karmada-controller-manager error log shows as below:

2022-08-26T01:43:46.835385736Z stderr F W0826 01:43:46.835129       1 customized.go:148] Failed calling webhook examples/workloads.example.com: failed calling webhook "examples/workloads.example.com": failed to call webhook: Post "https://172.18.0.6:443/interpreter-workload?timeout=3s": context deadline exceeded
2022-08-26T01:43:46.835568337Z stderr F E0826 01:43:46.835487       1 workstatus_controller.go:289] Failed to reflect status for object(Workload/karmadatest-nhq/workload-wh8) with resourceInterpreter.%!(EXTRA *errors.StatusError=Internal error occurred: failed calling webhook "examples/workloads.example.com": failed to call webhook: Post "https://172.18.0.6:443/interpreter-workload?timeout=3s": context deadline exceeded)

When we call ResourceInterpreter to reflect workload status failed, we didn't return err, so that work can not sync status again. So we need to return err immediately.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-controller-manager`/`karmada-agent`: Fixed an resource status can not be collected issue in case of Resource Interpreter returns an error.

@karmada-bot karmada-bot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/bug Categorizes issue or PR as related to a bug. labels Aug 26, 2022
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 26, 2022
Signed-off-by: changzhen <changzhen5@huawei.com>
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2022
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2022
@karmada-bot karmada-bot merged commit 308392d into karmada-io:master Aug 26, 2022
karmada-bot added a commit that referenced this pull request Aug 26, 2022
…upstream-release-1.2

Automated cherry pick of #2428: fix error of reflectStatus failed when call
@XiShanYongYe-Chang XiShanYongYe-Chang deleted the fix-bug-reflect-status branch August 31, 2022 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants