Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

karmadactl token uses factory to access cluster #2668

Merged
merged 1 commit into from
Oct 22, 2022

Conversation

lonelyCZ
Copy link
Member

Signed-off-by: lonelyCZ 531187475@qq.com

What type of PR is this?
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:
Part of #2349

Special notes for your reviewer:
/cc @carlory @helen-frank

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: lonelyCZ <531187475@qq.com>
@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 21, 2022
@karmada-bot
Copy link
Collaborator

@lonelyCZ: GitHub didn't allow me to request PR reviews from the following users: helen-frank.

Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Signed-off-by: lonelyCZ 531187475@qq.com

What type of PR is this?
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:
Part of #2349

Special notes for your reviewer:
/cc @carlory @helen-frank

Does this PR introduce a user-facing change?:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 21, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2668 (b2d3bbd) into master (dbb24d3) will increase coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2668      +/-   ##
==========================================
+ Coverage   27.08%   27.13%   +0.04%     
==========================================
  Files         189      189              
  Lines       19011    19003       -8     
==========================================
+ Hits         5150     5156       +6     
+ Misses      13499    13486      -13     
+ Partials      362      361       -1     
Flag Coverage Δ
unittests 27.13% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/karmadactl/karmadactl.go 0.00% <0.00%> (ø)
pkg/karmadactl/token.go 0.00% <0.00%> (ø)
pkg/search/proxy/store/util.go 95.32% <0.00%> (+1.75%) ⬆️
pkg/search/proxy/store/store.go 68.42% <0.00%> (+3.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@helen-frank
Copy link
Contributor

/lgtm

Can I apply to become a member of the karmada now @lonelyCZ

@karmada-bot
Copy link
Collaborator

@helen-frank: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Can I apply to become a member of the karmada now @lonelyCZ

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@carlory
Copy link
Member

carlory commented Oct 22, 2022

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2022
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2022
@karmada-bot karmada-bot merged commit a795d14 into karmada-io:master Oct 22, 2022
@lonelyCZ
Copy link
Member Author

Can I apply to become a member of the karmada now

Sure, welcome, thanks for your contributions, @helen-frank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants