-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
karmadactl token uses factory to access cluster #2668
Conversation
Signed-off-by: lonelyCZ <531187475@qq.com>
@lonelyCZ: GitHub didn't allow me to request PR reviews from the following users: helen-frank. Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #2668 +/- ##
==========================================
+ Coverage 27.08% 27.13% +0.04%
==========================================
Files 189 189
Lines 19011 19003 -8
==========================================
+ Hits 5150 5156 +6
+ Misses 13499 13486 -13
+ Partials 362 361 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
/lgtm Can I apply to become a member of the karmada now @lonelyCZ |
@helen-frank: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carlory, RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sure, welcome, thanks for your contributions, @helen-frank |
Signed-off-by: lonelyCZ 531187475@qq.com
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Part of #2349
Special notes for your reviewer:
/cc @carlory @helen-frank
Does this PR introduce a user-facing change?: