Fix karmadactl token that can't set --kubeconfig

[lonelyCZ]

Signed-off-by: lonelyCZ chengzhe@zju.edu.cn

What type of PR is this?

/kind bug

What this PR does / why we need it:
Fix that setting --kubeconfig and --karmada-context flags is invalid.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[RainbowMango]

How to reproduce it?

Which PR introduced this bug? We should figure out which release also needs this patch.

[lonelyCZ]

Which PR introduced this bug? We should figure out which release also needs this patch.

#2668 , it doesn't need patch.

How to reproduce it?

[root@master67 karmada]# _output/bin/linux/amd64/karmadactl token create --kubeconfig /etc/karmada/karmada-apiserver.config --karmada-context karmada-apiserver

--kubeconfig and --karmada-context is invalid, it still uses /root/.kube/config.

[codecov-commenter]

Codecov Report

Merging #2730 (54ea4f4) into master (f6780c2) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2730      +/-   ##
==========================================
+ Coverage   32.73%   32.75%   +0.02%     
==========================================
  Files         199      199              
  Lines       19401    19382      -19     
==========================================
- Hits         6350     6349       -1     
+ Misses      12697    12678      -19     
- Partials      354      355       +1     

Flag	Coverage Δ
unittests	32.75% <0.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/karmadactl/token.go	0.00% <0.00%> (ø)
pkg/util/worker.go	66.66% <0.00%> (-4.77%)	⬇️
pkg/search/proxy/store/util.go	94.73% <0.00%> (+1.16%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[RainbowMango]

I don't get why the previous flags not working. We do add the flags at :

karmada/pkg/karmadactl/token.go

Line 119 in bcd7814

tokenOpts.GlobalCommandOptions.AddFlags(cmd.Flags())

[lonelyCZ]

I don't get why the previous flags not working. We do add the flags at :

karmada/pkg/karmadactl/token.go

Line 119 in bcd7814

tokenOpts.GlobalCommandOptions.AddFlags(cmd.Flags())

Because we will directly use defaultConfigFlags, and not need to checkout the kubeconfig in subcommands.

karmada/pkg/karmadactl/karmadactl.go

Lines 27 to 28 in bcd7814

	// It composes the set of values necessary for obtaining a REST client config with default values set.
	defaultConfigFlags = genericclioptions.NewConfigFlags(true).WithDeprecatedPasswordFlag().WithDiscoveryBurst(300).WithDiscoveryQPS(50.0)

[RainbowMango]

/lgtm
/approve

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/karmadactl/OWNERS [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment