-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix that karmada-agent don't have permission to delete work
resources
#2902
Fix that karmada-agent don't have permission to delete work
resources
#2902
Conversation
Signed-off-by: lonelyCZ <chengzhe@zju.edu.cn>
/lgtm |
Codecov Report
@@ Coverage Diff @@
## master #2902 +/- ##
=======================================
Coverage 37.80% 37.80%
=======================================
Files 200 200
Lines 18461 18461
=======================================
Hits 6980 6980
Misses 11073 11073
Partials 408 408
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
How to reproduce it? Does this only happen on the one installed by |
Yes, I have updated the release-note. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
By the way, I updated the release note, please take a look it will be used in cherry-picked PRs. |
…-upstream-release-1.4 Automated cherry pick of #2902: Fix that karmada-agent don't have permission to delete work
…-upstream-release-1.3 Automated cherry pick of #2902: Fix that karmada-agent don't have permission to delete work
Signed-off-by: lonelyCZ chengzhe@zju.edu.cn
What type of PR is this?
/kind bug
What this PR does / why we need it:
karmada-agent
need to permission to deletework
resources.karmada/pkg/controllers/mcs/service_export_controller.go
Lines 312 to 322 in 472ccb5
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
release-1.3
andrelease-1.4
need this patch (cherry-pick)./cc @RainbowMango
Does this PR introduce a user-facing change?: