Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix resourceinterpretercustomizations webhook #2916

Merged
merged 1 commit into from
Dec 8, 2022
Merged

fix resourceinterpretercustomizations webhook #2916

merged 1 commit into from
Dec 8, 2022

Conversation

chaunceyjiang
Copy link
Member

@chaunceyjiang chaunceyjiang commented Dec 7, 2022 •
edited by RainbowMango
Loading

Signed-off-by: chaunceyjiang chaunceyjiang@gmail.com

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmadactl`: Fixed the default ValidatingWebhookConfiguration for `resourceinterpretercustomizations` not working issue.

@chaunceyjiang
fix resourceinterpretercustomizations webhook
2aa025d 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 7, 2022
@chaunceyjiang
Copy link
Member Author

I didn't test karmadactl before, only tested hack/local-up-karmada.sh, which is my dereliction of duty

@chaunceyjiang
Copy link
Member Author

chaunceyjiang commented Dec 7, 2022 •
edited
Loading

I think we should use the embed module instead of the webhook_configuration.go go file.

@XiShanYongYe-Chang
Copy link
Member

I think we should use the embed module instead of the webhook_configuration.go go file.

👍 This looks good, unifying the files to prevent similar errors in the future.

@RainbowMango
Copy link
Member

Seems #2915 and this PR don't conflict, that's great, we can cherry-pick them separately.

XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Dec 8, 2022
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XiShanYongYe-Chang
Copy link
Member

Hi @chaunceyjiang, can you help update the release note?

/kind bug

@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 8, 2022
@chaunceyjiang
Copy link
Member Author

can you help update the release note?

Updated.

@XiShanYongYe-Chang
Copy link
Member

/release-note-edit `karmadactl`: fix the bug that resourceinterpretercustomizations can be created repeatedly.

@chaunceyjiang, I update the component karmada-webhook to karmadactl.

@chaunceyjiang
Copy link
Member Author

Fixed bug where resourceinterpretercustomizations could be created repeatedly.

/release-note-edit `karmadactl`: fix the bug that resourceinterpretercustomizations can be created repeatedly.

@chaunceyjiang, I update the component karmada-webhook to karmadactl.

Done!

RainbowMango
RainbowMango approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
I bet you have tested it :).

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2022
@RainbowMango
Copy link
Member

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2022
@karmada-bot karmada-bot merged commit efb50ad into karmada-io:master Dec 8, 2022
@XiShanYongYe-Chang
Copy link
Member

Hi @chaunceyjiang, we need to cherry-pick this patch to the previous release-v1.4 branch.

@chaunceyjiang
Copy link
Member Author

I bet you have tested it :).

yes, 😂
image

@chaunceyjiang chaunceyjiang mentioned this pull request Dec 8, 2022
Merged
karmada-bot added a commit that referenced this pull request Dec 8, 2022
@karmada-bot
Merge pull request #2927 from chaunceyjiang/automated-cherry-pick-of-…
0e6f6eb 
…#2916-origin-release-1.4

Automated cherry pick of #2916: fix resourceinterpretercustomizations webhook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiShanYongYe-Chang XiShanYongYe-Chang XiShanYongYe-Chang left review comments

@RainbowMango RainbowMango RainbowMango approved these changes

@lonelyCZ lonelyCZ Awaiting requested review from lonelyCZ

@prodanlabs prodanlabs Awaiting requested review from prodanlabs

Assignees

@RainbowMango RainbowMango

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chaunceyjiang @XiShanYongYe-Chang @RainbowMango @karmada-bot