-
Notifications
You must be signed in to change notification settings - Fork 878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grant karmada-agent permission to access resourceinterpretercustomizations #2984
Conversation
…tions Signed-off-by: jwcesign <jiangwei115@huawei.com>
35c15fb
to
c174728
Compare
Codecov Report
@@ Coverage Diff @@
## master #2984 +/- ##
=======================================
Coverage 38.58% 38.58%
=======================================
Files 206 206
Lines 18820 18820
=======================================
Hits 7261 7261
Misses 11129 11129
Partials 430 430
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @jwcesign , have you tested it in your env? And please update the release-note to
and it could be cherry-picked to |
Updated.
|
Have we granted permission to |
|
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…-upstream-release-1.4 Automated cherry pick of #2984: Grant karmada-agent permission to access resourceinterpretercustomizations
Signed-off-by: jwcesign jiangwei115@huawei.com
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2982
Special notes for your reviewer:
none
Does this PR introduce a user-facing change?: