Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with Go patch release 1.19.5 #3067

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

yanggangtony
Copy link
Member

Signed-off-by: yanggang gang.yang@daocloud.io

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Karmada is now built with Golang 1.19.5.

Signed-off-by: yanggang <gang.yang@daocloud.io>
@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 25, 2023
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 25, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3067 (bed8e1a) into master (1558ab7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3067   +/-   ##
=======================================
  Coverage   43.25%   43.25%           
=======================================
  Files         207      207           
  Lines       19365    19365           
=======================================
  Hits         8377     8377           
  Misses      10523    10523           
  Partials      465      465           
Flag Coverage Δ
unittests 43.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

We are going to update Kubernetes dependencies to v1.26.1(see #3080), which is using Go 1.19.5.

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2023
@RainbowMango RainbowMango added this to the v1.5 milestone Jan 31, 2023
@karmada-bot karmada-bot merged commit fed2f26 into karmada-io:master Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants