Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: default interpreter supports cronJob aggregate status #3129

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

chaunceyjiang
Copy link
Member

Signed-off-by: chaunceyjiang chaunceyjiang@gmail.com

What type of PR is this?
/kind feature

What this PR does / why we need it:

image

We need to count the number of running jobs.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-controller-manager`: default interpreter supports cronJob aggregate status.

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 8, 2023
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 8, 2023
@chaunceyjiang
Copy link
Member Author

chaunceyjiang commented Feb 8, 2023

karmada

image

@XiShanYongYe-Chang
Copy link
Member

/assign

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me, can you help add the UT to cover the newly added codes?

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@karmada-bot karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 9, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3129 (bdf4a61) into master (5e81ea6) will increase coverage by 0.21%.
The diff coverage is 65.78%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #3129      +/-   ##
==========================================
+ Coverage   48.03%   48.24%   +0.21%     
==========================================
  Files         200      200              
  Lines       18000    18038      +38     
==========================================
+ Hits         8646     8703      +57     
+ Misses       8873     8850      -23     
- Partials      481      485       +4     
Flag Coverage Δ
unittests 48.24% <65.78%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...einterpreter/defaultinterpreter/aggregatestatus.go 71.02% <65.78%> (-0.52%) ⬇️
pkg/search/proxy/store/util.go 93.36% <0.00%> (+1.42%) ⬆️
pkg/karmadactl/cmdinit/utils/rbac.go 100.00% <0.00%> (+100.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~
/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2023
@karmada-bot karmada-bot merged commit 81cac76 into karmada-io:master Feb 10, 2023
@XiShanYongYe-Chang
Copy link
Member

Hi @chaunceyjiang, can you help update the doc on the website?

@chaunceyjiang
Copy link
Member Author

sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants