Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: fix the schedule function error return #346

Merged
merged 1 commit into from
May 17, 2021
Merged

scheduler: fix the schedule function error return #346

merged 1 commit into from
May 17, 2021

Conversation

Iceber
Copy link
Contributor

@Iceber Iceber commented May 17, 2021

Signed-off-by: Iceber Gu wei.cai-nat@daocloud.io

What type of PR is this?

/kind bug

What this PR does / why we need it:
When json.Marshal returns an error, scheduleResourceBinding and scheudleClusterResourceBinding should return an error
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: Iceber Gu <wei.cai-nat@daocloud.io>
@RainbowMango
Copy link
Member

cc @mrlihanbo
Thanks @Iceber

Copy link

@mrlihanbo mrlihanbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks @Iceber

@RainbowMango RainbowMango merged commit 4b5ec0c into karmada-io:master May 17, 2021
@Iceber Iceber deleted the fix-scheduler branch May 18, 2021 06:05
lfbear pushed a commit to lfbear/karmada that referenced this pull request May 20, 2021
Signed-off-by: Iceber Gu <wei.cai-nat@daocloud.io>
Signed-off-by: lfbear <lfbear@gmail.com>
XiShanYongYe-Chang pushed a commit to XiShanYongYe-Chang/karmada that referenced this pull request Aug 28, 2021
Signed-off-by: Iceber Gu <wei.cai-nat@daocloud.io>
jwcesign pushed a commit to jwcesign/karmada that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants