scheduler: fix the schedule function error return (karmada-io#346)

Signed-off-by: Iceber Gu <wei.cai-nat@daocloud.io>
XiShanYongYe-Chang · Aug 28, 2021 · 17eb626 · 17eb626
1 parent 36322f3
commit 17eb626
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/pkg/scheduler/scheduler.go b/pkg/scheduler/scheduler.go
@@ -431,6 +431,7 @@ func (s *Scheduler) scheduleResourceBinding(resourceBinding *workv1alpha1.Resour
 	placement, err := json.Marshal(policy.Spec.Placement)
 	if err != nil {
 		klog.Errorf("Failed to marshal placement of propagationPolicy %s/%s, error: %v", policy.Namespace, policy.Name, err)
+		return err
 	}
 
 	if binding.Annotations == nil {
@@ -463,6 +464,7 @@ func (s *Scheduler) scheduleClusterResourceBinding(clusterResourceBinding *workv
 	placement, err := json.Marshal(policy.Spec.Placement)
 	if err != nil {
 		klog.Errorf("Failed to marshal placement of clusterPropagationPolicy %s, error: %v", policy.Name, err)
+		return err
 	}
 
 	if binding.Annotations == nil {