Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing probability of failure in CLI workflow #3465

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

jwcesign
Copy link
Member

@jwcesign jwcesign commented Apr 25, 2023

What type of PR is this?
/kind failing-test

What this PR does / why we need it:

The test result is here: https://github.com/jwcesign/karmada/actions/runs/4795828813/jobs/8530865325

Which issue(s) this PR fixes:
Fixes #none

Special notes for your reviewer:
@Poor12

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Apr 25, 2023
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 25, 2023
@Poor12
Copy link
Member

Poor12 commented Apr 25, 2023

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2023
hack/util.sh Outdated Show resolved Hide resolved
Signed-off-by: jwcesign <jiangwei115@huawei.com>
@karmada-bot karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3465 (3dfaa2b) into master (8d32dc1) will increase coverage by 0.02%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #3465      +/-   ##
==========================================
+ Coverage   53.72%   53.75%   +0.02%     
==========================================
  Files         210      210              
  Lines       19109    19123      +14     
==========================================
+ Hits        10267    10279      +12     
- Misses       8290     8292       +2     
  Partials      552      552              
Flag Coverage Δ
unittests 53.75% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2023
@karmada-bot karmada-bot merged commit 0f84dd7 into karmada-io:master Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants