-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix_deploy_sh_base64_usage_parameter #3561
fix_deploy_sh_base64_usage_parameter #3561
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @Vacant2333! It looks like this is your first PR to karmada-io/karmada 🎉 |
Hear from https://stackoverflow.com/questions/75713408/decoding-base64-text-file-to-audio-file-returns-invalid-argument-of-input-file, on macOS the syntax is a little different. And I test it on CentOS7 & Ubuntu20, it also works:
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vacant2333 You might need to sign your commits, and you can follow the guidelines here:
https://github.com/karmada-io/karmada/pull/3561/checks?check_run_id=13629106744
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3561 +/- ##
==========================================
+ Coverage 52.98% 53.00% +0.01%
==========================================
Files 216 216
Lines 20026 20026
==========================================
+ Hits 10611 10614 +3
+ Misses 8845 8842 -3
Partials 570 570
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Vacant2333 <vacant2333@gmail.com>
…eter' into fix_deploy_sh_base64_usage_parameter
@Vacant2333: Adding label Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
ISSUE: #3560
fix "hack/deploy-local-karamada.sh" base64 usage in mac M1, in mac this usage should add "-i" or use "<" to redirect input
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: