Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_deploy_sh_base64_usage #3563

Merged

Conversation

Vacant2333
Copy link
Contributor

@Vacant2333 Vacant2333 commented May 21, 2023

What type of PR is this?
ISSUE: #3560

fix "hack/deploy-local-karamada.sh" base64 usage in mac M1, in mac this usage should add "-i" or use "<" to redirect input

from PR: #3561

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: Vacant2333 <vacant2333@gmail.com>
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 21, 2023
@XiShanYongYe-Chang
Copy link
Member

@Vacant2333 Thanks~
Ask @ikaven1024 to help take a look.
/cc @ikaven1024

Copy link
Member

@chaunceyjiang chaunceyjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch works fine in my local environment(MAC M1).

@ikaven1024
Copy link
Member

Also works well on my CentOS7 & Ubuntu20.

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3563 (00fad8c) into master (c6f52f1) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3563      +/-   ##
==========================================
- Coverage   52.98%   52.97%   -0.01%     
==========================================
  Files         216      216              
  Lines       20026    20026              
==========================================
- Hits        10611    10609       -2     
- Misses       8845     8847       +2     
  Partials      570      570              
Flag Coverage Δ
unittests 52.97% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@Vacant2333
Copy link
Contributor Author

may we need rerun the e2e test? seems like something timeout @XiShanYongYe-Chang

@XiShanYongYe-Chang
Copy link
Member

The flake test [ClusterAffinities] propagation testing when [ClusterPropagationPolicy] replica scheduling type is Duplicated schedule with multi clusterAffinity [It] propagate clusterRole and then update the cluster label we are now analysing, ask @RainbowMango to help rerun the ci.
/cc @RainbowMango

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@XiShanYongYe-Chang
Copy link
Member

@Vacant2333 Thank you for contribution~
I think it's ready to merge.
/cc @RainbowMango

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
on behalf of @ikaven1024

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2023
@karmada-bot karmada-bot merged commit 218a0b2 into karmada-io:master May 24, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants