-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix_deploy_sh_base64_usage #3563
fix_deploy_sh_base64_usage #3563
Conversation
Signed-off-by: Vacant2333 <vacant2333@gmail.com>
@Vacant2333 Thanks~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch works fine in my local environment(MAC M1).
Also works well on my CentOS7 & Ubuntu20. /lgtm |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3563 +/- ##
==========================================
- Coverage 52.98% 52.97% -0.01%
==========================================
Files 216 216
Lines 20026 20026
==========================================
- Hits 10611 10609 -2
- Misses 8845 8847 +2
Partials 570 570
Flags with carried forward coverage won't be shown. Click here to find out more. |
may we need rerun the e2e test? seems like something timeout @XiShanYongYe-Chang |
The flake test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@Vacant2333 Thank you for contribution~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
on behalf of @ikaven1024
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
ISSUE: #3560
fix "hack/deploy-local-karamada.sh" base64 usage in mac M1, in mac this usage should add "-i" or use "<" to redirect input
from PR: #3561
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: