Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Golang version from v1.19.5 to v1.20.4 #3565

Merged
merged 1 commit into from May 22, 2023

Conversation

RainbowMango
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR updates the default Go version for CI and releases bots to v1.20.4.

Since we are going to update the Kubernetes dependencies to v1.27.2 which requires Go1.20+.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Karmada(v1.6) is now built with Go1.20.4.

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 22, 2023
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 22, 2023

Codecov Report

Merging #3565 (11c1f17) into master (2cdc72f) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3565      +/-   ##
==========================================
- Coverage   53.00%   52.97%   -0.03%     
==========================================
  Files         216      216              
  Lines       20026    20026              
==========================================
- Hits        10614    10609       -5     
- Misses       8842     8846       +4     
- Partials      570      571       +1     
Flag Coverage Δ
unittests 52.97% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
@RainbowMango RainbowMango added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RainbowMango
Copy link
Member Author

cc @jwcesign

@jwcesign
Copy link
Member

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2023
@karmada-bot karmada-bot merged commit f38e57d into karmada-io:master May 22, 2023
12 checks passed
@RainbowMango RainbowMango deleted the pr_update_go_for_20 branch May 22, 2023 06:21
@RainbowMango RainbowMango added this to the v1.6 milestone Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants