work: fix workload name conflicts #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -198,7 +198,7 @@ func (c *WorkStatusController) handleDeleteEvent(key keys.FederatedKey) error { | |||
|
|
|||
| // Given the workload might has been deleted from informer cache, so that we can't get work object by it's label, | |||
| // we have to get work by naming rule as work's name also is binding's name and binding's name consist of workload's name and kind. | |||
There was a problem hiding this comment.
The comment needs an update as well, right?
There was a problem hiding this comment.
Right👍, I will fix it.
Signed-off-by: Garrybest <garrybest@foxmail.com>
RainbowMango
approved these changes
May 20, 2021
lfbear
pushed a commit
to lfbear/karmada
that referenced
this pull request
May 20, 2021
Signed-off-by: Garrybest <garrybest@foxmail.com> Signed-off-by: lfbear <lfbear@gmail.com>
XiShanYongYe-Chang
pushed a commit
to XiShanYongYe-Chang/karmada
that referenced
this pull request
Aug 28, 2021
Signed-off-by: Garrybest <garrybest@foxmail.com>
jwcesign
pushed a commit
to jwcesign/karmada
that referenced
this pull request
Jun 8, 2023
…mada-scheduler-doc fix redundance kubectl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Garrybest garrybest@foxmail.com
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #358
Special notes for your reviewer:
Does this PR introduce a user-facing change?: