-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
work: name conflicts when different workloads have the same name #358
Labels
kind/bug
Categorizes issue or PR as related to a bug.
Comments
Garrybest
added a commit
to Garrybest/karmada
that referenced
this issue
May 19, 2021
Signed-off-by: Garrybest <garrybest@foxmail.com>
/assign @Garrybest |
Karmada bot not ready now, (it will be soon), manually assign to you :) |
LGTM. |
LGTM |
Garrybest
added a commit
to Garrybest/karmada
that referenced
this issue
May 20, 2021
Signed-off-by: Garrybest <garrybest@foxmail.com>
RainbowMango
pushed a commit
that referenced
this issue
May 20, 2021
lfbear
pushed a commit
to lfbear/karmada
that referenced
this issue
May 20, 2021
Signed-off-by: Garrybest <garrybest@foxmail.com> Signed-off-by: lfbear <lfbear@gmail.com>
XiShanYongYe-Chang
pushed a commit
to XiShanYongYe-Chang/karmada
that referenced
this issue
Aug 28, 2021
Signed-off-by: Garrybest <garrybest@foxmail.com>
jwcesign
pushed a commit
to jwcesign/karmada
that referenced
this issue
Jun 8, 2023
Add eriecanal integration doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened:
When different workload have the same name, the work that creating by the ResourceBindingController will have the same name in one ExecutionSpaceName, which would cause execution chaos.
Reason: The work's name is the same with the resource binding, but it's namespace is associated with cluster. I suggest to adding namespace to generate works' name.
karmada/pkg/util/helper/binding.go
Lines 177 to 182 in 7a0d6c9
What you expected to happen:
The work's name may contain namespace to distinguish with each other.
How to reproduce it (as minimally and precisely as possible):
For example:
I create 2 deployment in 2 different namespace but having the same name, only one work will be created. When I delete them, the member cluster also runs one of a deployment which may cause resource leak.
[root@garryfang /data/garryfang/karmada/samples/nginx]# kubectl get deployments.apps -A NAMESPACE NAME READY UP-TO-DATE AVAILABLE AGE garrytest nginx 2/2 2 2 23s lynntest nginx 10/10 10 10 84s
[root@garryfang /data/garryfang/karmada/samples/nginx]# kubectl get works.work.karmada.io -A NAMESPACE NAME AGE karmada-es-member1 garrytest-namespace 23h karmada-es-member1 lynntest-namespace 4d12h karmada-es-member1 nginx-deployment 99s karmada-es-member2 garrytest-namespace 23h karmada-es-member2 lynntest-namespace 4d12h karmada-es-member3 garrytest-namespace 23h karmada-es-member3 lynntest-namespace 4d12h
Only one work exists.
Anything else we need to know?:
Environment:
The text was updated successfully, but these errors were encountered: