Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update lifted files to k8s 1.26 #3613

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Conversation

zishen
Copy link
Member

@zishen zishen commented May 31, 2023

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
For kamarda is based on k8s 1.26, but most lifted files are in 1.23.
So we need synchronize files to version 1.26 of k8s.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
update lifted files to k8s 1.26

Does this PR introduce a user-facing change?:
NONE

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 31, 2023
@karmada-bot karmada-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 31, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2023

Codecov Report

Merging #3613 (a947eb2) into master (2d22b74) will decrease coverage by 0.01%.
The diff coverage is 35.82%.

❗ Current head a947eb2 differs from pull request most recent head 51bbfa0. Consider uploading reports for the commit 51bbfa0 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3613      +/-   ##
==========================================
- Coverage   55.68%   55.67%   -0.01%     
==========================================
  Files         225      225              
  Lines       21313    21330      +17     
==========================================
+ Hits        11868    11876       +8     
- Misses       8813     8820       +7     
- Partials      632      634       +2     
Flag Coverage Δ
unittests 55.67% <35.82%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/util/lifted/corehelpers.go 7.54% <ø> (ø)
pkg/util/lifted/corev1helpers.go 27.77% <ø> (+11.11%) ⬆️
pkg/util/lifted/corevalidation.go 37.14% <ø> (ø)
pkg/util/lifted/genutils.go 78.57% <ø> (ø)
pkg/util/lifted/podtemplate.go 0.00% <ø> (ø)
pkg/util/lifted/requestinfo.go 84.61% <0.00%> (-10.29%) ⬇️
pkg/util/lifted/resourcename.go 0.00% <ø> (ø)
...ted/scheduler/framework/parallelize/parallelism.go 56.25% <ø> (ø)
pkg/util/lifted/taint.go 91.89% <ø> (ø)
pkg/util/lifted/validateclustertaints.go 0.00% <0.00%> (ø)
... and 8 more

... and 1 file with indirect coverage changes

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zishen
Copy link
Member Author

zishen commented Jun 1, 2023

/cc @RainbowMango
pls take a look.

@XiShanYongYe-Chang
Copy link
Member

Thanks, I will take a review ASAP.

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~

pkg/util/lifted/deployment.go Show resolved Hide resolved
pkg/util/selector.go Outdated Show resolved Hide resolved
pkg/util/lifted/objectwatcher.go Outdated Show resolved Hide resolved
pkg/util/lifted/requestinfo.go Outdated Show resolved Hide resolved
@karmada-bot karmada-bot added the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Jun 12, 2023
@zishen zishen closed this Jun 26, 2023
@karmada-bot karmada-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 26, 2023
@zishen zishen reopened this Jul 6, 2023
@karmada-bot karmada-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 6, 2023
@zishen zishen force-pushed the master branch 2 times, most recently from a97edfe to a536718 Compare July 7, 2023 02:00
@karmada-bot karmada-bot added do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 13, 2023
@karmada-bot karmada-bot removed the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Jul 13, 2023
@zishen zishen force-pushed the master branch 4 times, most recently from a73205f to f134057 Compare July 13, 2023 12:44
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2023
Signed-off-by: Tanggui Bian <softwarebtg@163.com>
@karmada-bot karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2023
@zishen
Copy link
Member Author

zishen commented Jul 17, 2023

some thing go wrong.
image
Can you help me to retry it?
@RainbowMango

@RainbowMango
Copy link
Member

done.

@XiShanYongYe-Chang
Copy link
Member

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2023
@zishen
Copy link
Member Author

zishen commented Jul 19, 2023

cc @RainbowMango It's ready to go.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango, XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2023
@karmada-bot karmada-bot merged commit d27faea into karmada-io:master Jul 19, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants