-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update lifted file requestinfo.go logical #3792
Conversation
@XiShanYongYe-Chang PTAL |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3792 +/- ##
==========================================
- Coverage 55.68% 55.64% -0.04%
==========================================
Files 225 225
Lines 21313 21319 +6
==========================================
- Hits 11868 11863 -5
- Misses 8813 8823 +10
- Partials 632 633 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, can you help update the title more specific?
OK, How about "update lifted file equestinfo.go logical "? |
What dose equestinfo.go mean? I see you don't update this file? |
Signed-off-by: zishen <softwarebtg@163.com>
so, remove logical? or just use "update lifted files to come with k8s version 1.26 ?" |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
the lifted file pkg\util\lifted\objectwatcher.go and requestinfo.go changed some logical when synchronization them with community.
Which issue(s) this PR fixes:
some logical change discuss in #3613
Special notes for your reviewer:
update lifted files objectwatcher.go and requestinfo.go
Does this PR introduce a user-facing change?:
NONE