Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update lifted file requestinfo.go logical #3792

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

zishen
Copy link
Member

@zishen zishen commented Jul 13, 2023

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
the lifted file pkg\util\lifted\objectwatcher.go and requestinfo.go changed some logical when synchronization them with community.

Which issue(s) this PR fixes:
some logical change discuss in #3613

Special notes for your reviewer:
update lifted files objectwatcher.go and requestinfo.go

Does this PR introduce a user-facing change?:
NONE

@karmada-bot karmada-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 13, 2023
@zishen
Copy link
Member Author

zishen commented Jul 13, 2023

@XiShanYongYe-Chang PTAL

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2023

Codecov Report

Merging #3792 (b7e6826) into master (2d22b74) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3792      +/-   ##
==========================================
- Coverage   55.68%   55.64%   -0.04%     
==========================================
  Files         225      225              
  Lines       21313    21319       +6     
==========================================
- Hits        11868    11863       -5     
- Misses       8813     8823      +10     
- Partials      632      633       +1     
Flag Coverage Δ
unittests 55.64% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/util/lifted/objectwatcher.go 96.15% <ø> (ø)
pkg/util/lifted/requestinfo.go 84.61% <0.00%> (-10.29%) ⬇️

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can you help update the title more specific?

pkg/util/lifted/objectwatcher.go Outdated Show resolved Hide resolved
@zishen zishen changed the title update some lifted file logical update lifted file equestinfo.go logical Jul 15, 2023
@zishen
Copy link
Member Author

zishen commented Jul 15, 2023

Thanks, can you help update the title more specific?

OK, How about "update lifted file equestinfo.go logical "?
I really don't know how to name changes in lifted file.

@XiShanYongYe-Chang
Copy link
Member

What dose equestinfo.go mean? I see you don't update this file?

Signed-off-by: zishen <softwarebtg@163.com>
@zishen
Copy link
Member Author

zishen commented Jul 17, 2023

What dose equestinfo.go mean? I see you don't update this file?

so, remove logical? or just use "update lifted files to come with k8s version 1.26 ?"

@XiShanYongYe-Chang
Copy link
Member

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2023
@zishen zishen changed the title update lifted file equestinfo.go logical update lifted file requestinfo.go logical Jul 17, 2023
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2023
@karmada-bot karmada-bot merged commit f8f82cc into karmada-io:master Jul 17, 2023
12 checks passed
@zishen zishen deleted the lifted-update branch July 25, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants