-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support namespace to use regexp for resourceSelector of cpp and cop #3656
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e2e failed by occasional failure(setup e2e environment failed). |
This issue is tracked by https://github.com/karmada-io/karmada/actions/runs/5211054867/jobs/9403105260?pr=3656
|
04fe1d0
to
a3417ac
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3656 +/- ##
=======================================
Coverage 55.69% 55.69%
=======================================
Files 222 222
Lines 21195 21218 +23
=======================================
+ Hits 11805 11818 +13
- Misses 8763 8771 +8
- Partials 627 629 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/cc @RainbowMango @GitHubxsy who may be interested in this feature. |
Very nice feature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the failing CI. I'll take a look later.
Signed-off-by: Poor12 <shentiecheng@huawei.com>
Just realized, that this approach might conflict with the PropagationPolicy Preemption feature:
My concern is we can't figure out if the |
I got it. One option is that we can ensure that these two features won't be enabled in the meanwhile. I am not sure whether there are many resources with the same name and different ns. |
I'm trying to figure out which PR/Issue should be included in the coming v1.7 release which is planned at the end of this month. From an API perspective, I think each field should have clear meanings, otherwise, we might face challenges for both users and implementations. |
@RainbowMango: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
For cpp and cop, we expect resourceSelectors can hit multiple namespaces with the similar format, otherwise we may need to edit cpp and cop when we add a new namespace.
Assume that there is a use case that all business departments are registered to Karmada uniformly and isolated through different namespaces. It is agreed to use the format of "test-xxx" uniformly. Now they have registered two departments and have a global cpp to propagate their applications. Once they add a new department, they do not want to edit the cpp because they may cause rescheduling of applications.
In that case, the following config may help.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: