Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add log for resourceinterpreter_test #3859

Closed
wants to merge 1 commit into from

Conversation

chaosi-zju
Copy link
Member

What type of PR is this?

/kind flake

What this PR does / why we need it:

add little log to debug issue

Which issue(s) this PR fixes:

#3825

Special notes for your reviewer:
@XiShanYongYe-Chang @RainbowMango

Does this PR introduce a user-facing change?:
none

@karmada-bot karmada-bot added the kind/flake Categorizes issue or PR as related to a flaky test. label Jul 29, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign garrybest after the PR has been reviewed.
You can assign the PR to them by writing /assign @garrybest in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 29, 2023
pkg/util/common.go Outdated Show resolved Hide resolved
pkg/util/common.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2023

Codecov Report

Merging #3859 (f2fe1db) into master (85a4f50) will decrease coverage by 0.01%.
Report is 2 commits behind head on master.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3859      +/-   ##
==========================================
- Coverage   55.18%   55.18%   -0.01%     
==========================================
  Files         227      227              
  Lines       21658    21678      +20     
==========================================
+ Hits        11953    11963      +10     
- Misses       9069     9078       +9     
- Partials      636      637       +1     
Flag Coverage Δ
unittests 55.18% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/util/common.go 50.00% <0.00%> (-7.90%) ⬇️
...ook/resourceinterpretercustomization/validating.go 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

@karmada-bot karmada-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 29, 2023
Signed-off-by: chaosi-zju <chaosi@zju.edu.cn>
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~

pkg/util/common.go Show resolved Hide resolved
@chaosi-zju
Copy link
Member Author

the problem has been fixed by #3909
/close

@karmada-bot
Copy link
Collaborator

@chaosi-zju: Closed this PR.

In response to this:

the problem has been fixed by #3909
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/flake Categorizes issue or PR as related to a flaky test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants