Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update validate-resourceinterpretercustomization webhook timeout from 3s to 10s #3909

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

chaosi-zju
Copy link
Member

@chaosi-zju chaosi-zju commented Aug 7, 2023

What type of PR is this?

/kind flake

What this PR does / why we need it:

fix e2e test accidently timeout failure.

Which issue(s) this PR fixes:
#3825

Special notes for your reviewer:
@chaunceyjiang @XiShanYongYe-Chang

Does this PR introduce a user-facing change?:


… 3s to 10s

Signed-off-by: chaosi-zju <chaosi@zju.edu.cn>
@karmada-bot karmada-bot added the kind/flake Categorizes issue or PR as related to a flaky test. label Aug 7, 2023
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 7, 2023
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2023
@XiShanYongYe-Chang
Copy link
Member

/cc @chaunceyjiang

Copy link
Member

@chaunceyjiang chaunceyjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2023
@karmada-bot karmada-bot merged commit 241c9b4 into karmada-io:master Aug 8, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/flake Categorizes issue or PR as related to a flaky test. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants