-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[karmadactl get] judge with label on the resources determine whether resource is adopted by Karmada #3910
[karmadactl get] judge with label on the resources determine whether resource is adopted by Karmada #3910
Conversation
/cc @lonelyCZ @QAQ-rookie |
@XiShanYongYe-Chang: GitHub didn't allow me to request PR reviews from the following users: QAQ-rookie. Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3910 +/- ##
=======================================
Coverage 54.83% 54.83%
=======================================
Files 229 229
Lines 21946 21946
=======================================
Hits 12033 12033
Misses 9274 9274
Partials 639 639
Flags with carried forward coverage won't be shown. Click here to find out more. |
Looks nice, thanks for your work, I will look it ASAP. /assign |
+1 |
15cd8e2
to
7fcd0e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tested it in my env, it worked fine.
LGTM!
…and to determine whether resource is managed by Karmada Signed-off-by: changzhen <changzhen5@huawei.com>
7fcd0e4
to
0cf3c07
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
We have added labels to the resources in the member cluster to indicate whether the current resource is propagated by Karmada:
karmada/pkg/util/constants.go
Lines 26 to 30 in 1953a0e
Therefore, we can directly process this label in the
karmadactl get
command, without needing to retrieve RB/CRB resources.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
One reason for this change is that we cannot assume that users using karmadactl by default have the authority to get rb/crb resources.
Does this PR introduce a user-facing change?: