-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add license and verify license for code file #4204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can introduce another verification, like hack/verify-licenses.sh
, which can be included in lint.
aa07daf
to
1bb5bfa
Compare
Done~ |
pkg/controllers/hpareplicassyncer/hpa_replicas_syncer_controller.go
Outdated
Show resolved
Hide resolved
7ab49be
to
cbd0507
Compare
7d2fd8b
to
5ba4fa7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4204 +/- ##
==========================================
- Coverage 52.80% 52.77% -0.03%
==========================================
Files 240 240
Lines 23606 23606
==========================================
- Hits 12464 12459 -5
- Misses 10463 10467 +4
- Partials 679 680 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
All fixed, PTAL Thanks~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
b245ccf
to
b2be714
Compare
Signed-off-by: zhy76 <958474674@qq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thank you very much @zhy76 , it really helps!
@jwcesign @ikaven1024 @whitewindmills Do you have any further comments?
This PR just introduced hack/verify-licenses.sh
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #4101
Special notes for your reviewer:
Does this PR introduce a user-facing change?: