Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add license and verify license for code file #4204

Merged
merged 1 commit into from
Nov 22, 2023
Merged

feat: add license and verify license for code file #4204

merged 1 commit into from
Nov 22, 2023

Conversation

zhy76
Copy link
Member

@zhy76 zhy76 commented Nov 2, 2023

What type of PR is this?
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #4101

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 2, 2023
@karmada-bot karmada-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 2, 2023
@RainbowMango RainbowMango mentioned this pull request Nov 2, 2023
Closed
jwcesign
jwcesign reviewed Nov 2, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
RainbowMango
RainbowMango reviewed Nov 2, 2023
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can introduce another verification, like hack/verify-licenses.sh, which can be included in lint.

cluster/images/Dockerfile Outdated Show resolved Hide resolved
ikaven1024
ikaven1024 reviewed Nov 2, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@zhy76 zhy76 force-pushed the copyright branch 3 times, most recently from aa07daf to 1bb5bfa Compare November 4, 2023 14:50
@zhy76 zhy76 changed the title feat: add copyright in the header of the code file feat: add license and verify license for code file Nov 4, 2023
@zhy76
Copy link
Member Author

zhy76 commented Nov 4, 2023

Maybe we can introduce another verification, like hack/verify-licenses.sh, which can be included in lint.

Done~

@zhy76 zhy76 force-pushed the copyright branch 3 times, most recently from 7ab49be to cbd0507 Compare November 8, 2023 10:33
RainbowMango
RainbowMango reviewed Nov 9, 2023
View reviewed changes
cmd/agent/app/agent.go Outdated Show resolved Hide resolved
@zhy76 zhy76 force-pushed the copyright branch 2 times, most recently from 7d2fd8b to 5ba4fa7 Compare November 13, 2023 05:23
@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5e27024) 52.80% compared to head (adef1e5) 52.77%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4204      +/-   ##
==========================================
- Coverage   52.80%   52.77%   -0.03%     
==========================================
  Files         240      240              
  Lines       23606    23606              
==========================================
- Hits        12464    12459       -5     
- Misses      10463    10467       +4     
- Partials      679      680       +1
Flag Coverage Δ
unittests 52.77% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhy76
Copy link
Member Author

zhy76 commented Nov 13, 2023

All fixed, PTAL Thanks~

RainbowMango
RainbowMango reviewed Nov 14, 2023
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Makefile Outdated Show resolved Hide resolved
@zhy76 zhy76 force-pushed the copyright branch 6 times, most recently from b245ccf to b2be714 Compare November 16, 2023 02:29
RainbowMango
RainbowMango reviewed Nov 16, 2023
View reviewed changes
hack/verify-license.sh Outdated Show resolved Hide resolved
hack/verify-license.sh Outdated Show resolved Hide resolved
@zhy76
feat: add license and verify license for code file
adef1e5 
Signed-off-by: zhy76 <958474674@qq.com>
RainbowMango
RainbowMango reviewed Nov 16, 2023
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you very much @zhy76 , it really helps!

@jwcesign @ikaven1024 @whitewindmills Do you have any further comments?
This PR just introduced hack/verify-licenses.sh.

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2023
@zhy76 zhy76 mentioned this pull request Nov 21, 2023
Closed
8 tasks
RainbowMango
RainbowMango approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2023
@karmada-bot karmada-bot merged commit 4fe9dff into karmada-io:master Nov 22, 2023
12 checks passed
@RainbowMango RainbowMango mentioned this pull request Nov 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikaven1024 ikaven1024 ikaven1024 left review comments

@jwcesign jwcesign jwcesign left review comments

@whitewindmills whitewindmills whitewindmills left review comments

@RainbowMango RainbowMango RainbowMango approved these changes

@calvin0327 calvin0327 Awaiting requested review from calvin0327

@carlory carlory Awaiting requested review from carlory

@chaunceyjiang chaunceyjiang Awaiting requested review from chaunceyjiang

@Garrybest Garrybest Awaiting requested review from Garrybest

@huntsman-li huntsman-li Awaiting requested review from huntsman-li

@iawia002 iawia002 Awaiting requested review from iawia002

@lonelyCZ lonelyCZ Awaiting requested review from lonelyCZ

@mrlihanbo mrlihanbo Awaiting requested review from mrlihanbo

@Poor12 Poor12 Awaiting requested review from Poor12

@prodanlabs prodanlabs Awaiting requested review from prodanlabs

@wuyingjun-lucky wuyingjun-lucky Awaiting requested review from wuyingjun-lucky

@XiShanYongYe-Chang XiShanYongYe-Chang Awaiting requested review from XiShanYongYe-Chang

@yike21 yike21 Awaiting requested review from yike21

Assignees

@RainbowMango RainbowMango

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CopyRight needs to be added in the header of the code file
7 participants
@zhy76 @codecov-commenter @karmada-bot @RainbowMango @ikaven1024 @jwcesign @whitewindmills