New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup: enable revive(var-naming rule) checking #4496
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4496 +/- ##
==========================================
- Coverage 51.87% 51.85% -0.02%
==========================================
Files 243 243
Lines 24183 24183
==========================================
- Hits 12545 12541 -4
- Misses 10958 10961 +3
- Partials 680 681 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold
Please feel free to unhold after #4492, I'm afraid there is another conflict.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: jwcesign <jwcesign@gmail.com>
/lgtm |
/hold cancel |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
cleanup: enable revive(var-naming rule) checking
Which issue(s) this PR fixes:
Part of #4490
Special notes for your reviewer:
none
Does this PR introduce a user-facing change?: