Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: enable revive(var-naming rule) checking #4496

Merged
merged 1 commit into from Jan 10, 2024

Conversation

jwcesign
Copy link
Member

@jwcesign jwcesign commented Jan 2, 2024

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
cleanup: enable revive(var-naming rule) checking

Which issue(s) this PR fixes:
Part of #4490

Special notes for your reviewer:
none

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 2, 2024
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d10b6d8) 51.87% compared to head (947a80e) 51.85%.

Files Patch % Lines
pkg/util/proxy/upgrade_dialer.go 0.00% 2 Missing ⚠️
...ependenciesdistributor/dependencies_distributor.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4496      +/-   ##
==========================================
- Coverage   51.87%   51.85%   -0.02%     
==========================================
  Files         243      243              
  Lines       24183    24183              
==========================================
- Hits        12545    12541       -4     
- Misses      10958    10961       +3     
- Partials      680      681       +1     
Flag Coverage Δ
unittests 51.85% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karmada-bot karmada-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 9, 2024
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/hold
Please feel free to unhold after #4492, I'm afraid there is another conflict.

@karmada-bot karmada-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 9, 2024
@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2024
Signed-off-by: jwcesign <jwcesign@gmail.com>
@karmada-bot karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2024
@RainbowMango
Copy link
Member

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2024
@RainbowMango
Copy link
Member

/hold cancel

@karmada-bot karmada-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2024
@karmada-bot karmada-bot merged commit 4b13b60 into karmada-io:master Jan 10, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants