Added additional sort example #468

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@mdpatrick

Very prominent feature of elasticsearch is that it allows multi-field sorting. Added it to readme for tire.

Added additional sort example
Very prominent feature of elasticsearch is that it allows multi-field sorting. Added it to readme for tire.
@karmi

This comment has been minimized.

Show comment Hide comment
@karmi

karmi Oct 17, 2012

Owner

Yes, maybe, but definitely without the comment... Still on the fence with this. We don't want to explain everything about elasticsearch in the README, do we?

Owner

karmi commented Oct 17, 2012

Yes, maybe, but definitely without the comment... Still on the fence with this. We don't want to explain everything about elasticsearch in the README, do we?

@karmi

This comment has been minimized.

Show comment Hide comment

@karmi karmi closed this Oct 19, 2012

@mdpatrick

This comment has been minimized.

Show comment Hide comment
@mdpatrick

mdpatrick Oct 19, 2012

Would you be OK with me re-submitting the PR with the change I made less the comment?

Would you be OK with me re-submitting the PR with the change I made less the comment?

@karmi

This comment has been minimized.

Show comment Hide comment
@karmi

karmi Oct 19, 2012

Owner

@mdpatrick Absolutely, if you can add the documentation into those places (preferably in YARDoc format, see eg. https://github.com/karmi/tire/blob/master/lib/tire/alias.rb)!

I'm sorry but I don't wanna stretch the README too far -- some people have trouble reading it as it is :)

Owner

karmi commented Oct 19, 2012

@mdpatrick Absolutely, if you can add the documentation into those places (preferably in YARDoc format, see eg. https://github.com/karmi/tire/blob/master/lib/tire/alias.rb)!

I'm sorry but I don't wanna stretch the README too far -- some people have trouble reading it as it is :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment