This repository has been archived by the owner on Jun 30, 2018. It is now read-only.
Added additional sort example #468
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Very prominent feature of elasticsearch is that it allows multi-field sorting. Added it to readme for tire.
|
Yes, maybe, but definitely without the comment... Still on the fence with this. We don't want to explain everything about elasticsearch in the README, do we? |
|
Should be really properly documented in https://github.com/karmi/tire/blob/master/lib/tire/search/sort.rb and https://github.com/karmi/tire/blob/master/lib/tire/search.rb#L60-63 ... |
|
Would you be OK with me re-submitting the PR with the change I made less the comment? |
|
@mdpatrick Absolutely, if you can add the documentation into those places (preferably in YARDoc format, see eg. https://github.com/karmi/tire/blob/master/lib/tire/alias.rb)! I'm sorry but I don't wanna stretch the README too far -- some people have trouble reading it as it is :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very prominent feature of elasticsearch is that it allows multi-field sorting. Added it to readme for tire.